netcore2.0, bot_message return values, ephemeral messaging #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a bot_message subtype.
… deleted users/ bots
…t_id Add ephemeral message and bot
gpailler
added a commit
that referenced
this pull request
Nov 1, 2018
Added support of netstandard 2.0 to avoid a warning message when using SlackAPI in netcore2.0 Added bot_message return values Added ephemeral messaging
Collaborator
|
PR applied in the scope of #142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three things:
Minor change:
Filters the users during the unit test so that it doesn't include deleted users. Deleted users can have null values which can cause a false failure in the unit test.