Created an option to find modules via identifiers#327
Closed
Conversation
Contributor
FHieser
requested changes
Aug 17, 2023
Contributor
Author
Contributor
Author
|
Added the documentation for The
|
…tracts into saxenism/issue-317-same-name-modules
Contributor
|
The changes will be implemented with the #371 PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



As a fix for the issue mentioned by the auditors in issue #317 regarding the
findModuleAddressInOrchestratornot designed to handle the cases where multiple modules with the same name are being used, I have made a few changes tofindModuleAddressInOrchestrator.Since the URL of a module is much less likely to be the same as other modules, I have replaced the query string from the module title to the module URL.
And since, it is technically possible to have multiple modules with the same URL, i have also given an option to search for module address using a unique module identifier.