Skip to content

Authorizer codereview fixes #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xNuggan merged 37 commits into from
Aug 25, 2023
Merged

Authorizer codereview fixes #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
693ff34
first batch of restructuring
0xNuggan Jul 28, 2023
c1f41c2
move roles to module
0xNuggan Jul 28, 2023
d1e53c8
remove moduleManagerRoles
0xNuggan Jul 28, 2023
90923ac
make roleAuthorizer default
0xNuggan Aug 1, 2023
3110114
Merge branch 'main' into 292-authorization-cleanup
0xNuggan Aug 1, 2023
c24e261
fix singlevote tests
0xNuggan Aug 1, 2023
b68c137
fix some todos
0xNuggan Aug 2, 2023
908a192
Merge branch 'main' into 292-authorization-cleanup
0xNuggan Aug 2, 2023
4f600b8
more merge fixes
0xNuggan Aug 2, 2023
e0580a5
fix singlevotegovernor tests
0xNuggan Aug 2, 2023
891b3dc
authorizer housekeeping
0xNuggan Aug 2, 2023
ee19bcf
add missing tests
0xNuggan Aug 2, 2023
6241b06
further cleanup
0xNuggan Aug 2, 2023
50200d3
format
0xNuggan Aug 2, 2023
03ded17
fix code review issues
0xNuggan Aug 3, 2023
beb6ac1
add singleVoteLifecycle (not finished))
0xNuggan Aug 4, 2023
0d13db6
finish e2e
0xNuggan Aug 4, 2023
4f50b53
fix scripts
0xNuggan Aug 4, 2023
ae49d48
update lcov
0xNuggan Aug 4, 2023
e135e28
remove comment
0xNuggan Aug 4, 2023
a93080b
correct documentation typo
0xNuggan Aug 8, 2023
974d019
more review fixes
0xNuggan Aug 9, 2023
9d8581a
allow for token gated global roles
0xNuggan Aug 9, 2023
13f765f
remove selfManaged logic
0xNuggan Aug 9, 2023
3877554
first steps to change role format
0xNuggan Aug 10, 2023
313e5a0
partial fixes in tests
0xNuggan Aug 14, 2023
9c1d106
forge update
0xNuggan Aug 15, 2023
588b591
Merge branch 'main' into authorizer-codereview-fixes
0xNuggan Aug 16, 2023
e102781
fix test setup funcs
0xNuggan Aug 16, 2023
35bf37c
fix rest of tests
0xNuggan Aug 16, 2023
2f3b0d6
add missing test + cleanup
0xNuggan Aug 16, 2023
6819f3b
Felix review fixes
0xNuggan Aug 25, 2023
9c4901d
fix lib version bug
0xNuggan Aug 25, 2023
9402473
Merge branch 'main' into authorizer-codereview-fixes
FHieser Aug 25, 2023
6ac1865
solve merge conflicts
FHieser Aug 25, 2023
ca3cf7a
Update .gitmodules
0xNuggan Aug 25, 2023
789b714
Merge branch 'authorizer-codereview-fixes' of github.com:InverterNetw…
0xNuggan Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
457 changes: 222 additions & 235 deletions .gas-snapshot
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
url = https://github.com/foundry-rs/forge-std
[submodule "lib/openzeppelin-contracts"]
path = lib/openzeppelin-contracts
url = https://github.com/OpenZeppelin/openzeppelin-contracts
url = https://github.com/openzeppelin/openzeppelin-contracts
[submodule "lib/openzeppelin-contracts-upgradeable"]
path = lib/openzeppelin-contracts-upgradeable
url = https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable
url = https://github.com/openzeppelin/openzeppelin-contracts-upgradeable
Loading