SC-147: Security Review - #350 BondingCurveFndgMgr issues#414
Merged
Conversation
Zitzak
added
audit-fix
high prio
Security Review Requirement
marvinkruse
changed the title
marvinkruse
changed the title
Zitzak
force-pushed
the
sc-147-security-review-pr350-bonding-curve-funding-manager
branch
from
be91543 to
bf2a0cc
Compare
FHieser
reviewed
Feb 13, 2024
Contributor
FHieser
left a comment
FHieser
left a comment
There was a problem hiding this comment.
First two solutions look good.
The last change doesnt make any sense to me.
What is happening there?
...undingManager/bondingCurveFundingManager/BancorVirtualSupplyBondingCurveFundingManager.t.sol
Show resolved
Hide resolved
...undingManager/bondingCurveFundingManager/BancorVirtualSupplyBondingCurveFundingManager.t.sol
Show resolved
Hide resolved
FHieser
approved these changes
Feb 13, 2024
...undingManager/bondingCurveFundingManager/BancorVirtualSupplyBondingCurveFundingManager.t.sol
Show resolved
Hide resolved
Zitzak
deleted the
sc-147-security-review-pr350-bonding-curve-funding-manager
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done?
Please note
Implements