Conversation
Zitzak
requested changes
Dec 5, 2024
src/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.sol
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
…ondingCurveBase_v1.sol Co-authored-by: Marvin <43185740+Zitzak@users.noreply.github.com>
This reverts commit 32f9bb3.
Contributor
Author
|
@Zitzak could you rereview pls? |
…om-buy-and-sell-in
marvinkruse
requested changes
Dec 6, 2024
Member
marvinkruse
left a comment
marvinkruse
left a comment
There was a problem hiding this comment.
As mentioned in the other PR: please do not merge this unless I reviewed it, at least until we are all fully used to the Inverter Standard. I'll make sure to quickly review once I'm asked to look at it.
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
test/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.t.sol
Outdated
Show resolved
Hide resolved
test/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.t.sol
Outdated
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IFM_BC_Bancor_Redeeming_VirtualSupply_v1.sol
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IFM_BC_Bancor_Redeeming_VirtualSupply_v1.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: Marvin Kruse <marvinkruse@users.noreply.github.com>
…om-buy-and-sell-in
…om-buy-and-sell-in
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
marvinkruse
requested changes
Dec 13, 2024
src/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
test/modules/fundingManager/bondingCurve/abstracts/RedeemingBondingCurveBase_v1.t.sol
Outdated
Show resolved
Hide resolved
marvinkruse
approved these changes
Dec 13, 2024
marvinkruse
reviewed
Dec 13, 2024
src/modules/fundingManager/bondingCurve/interfaces/IFM_BC_Bancor_Redeeming_VirtualSupply_v1.sol
Outdated
Show resolved
Hide resolved
src/modules/fundingManager/bondingCurve/interfaces/IRedeemingBondingCurveBase_v1.sol
Outdated
Show resolved
Hide resolved
Member
|
Can be merged from my side. Please remember to choose a good title for the commit and not just take the PRs name. |
Zitzak
approved these changes
Dec 13, 2024
Zitzak
deleted the
sc-847-task-remove-not-needed-safety-check-from-buy-and-sell-in
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing an unnecessary check from the RedeemingBondingCurveBase
The removed code checks if enough collateral tokens are stored in the contract to do a sell operation.
This is useless in case of a transfer for example as the transfer would fail anyway in case
that there are not enough tokens in the contract.
With this removal we leave it to the PaymentProcessorLogic to fail/handle in case there is not enough collateral to transfer