Skip to content

[Post-Audit] Revised Payment Order Struct#717

Merged
0xNuggan merged 19 commits intodevfrom
audit-payment-order-struct
Feb 21, 2025
Merged

[Post-Audit] Revised Payment Order Struct#717
0xNuggan merged 19 commits intodevfrom
audit-payment-order-struct

Conversation

@0xNuggan
Copy link
Contributor

@0xNuggan 0xNuggan commented Feb 10, 2025 •
edited by marvinkruse
Loading

PR to merge the new PaymentOrder struct.

Still missing:

  • Rename all contracts with interface changes to V2, + their tests

@0xNuggan 0xNuggan requested a review from marvinkruse February 10, 2025 12:32
@0xNuggan 0xNuggan mentioned this pull request Feb 10, 2025
Closed
0xNuggan and others added 3 commits February 10, 2025 15:59
@0xNuggan
contract renaming to V2
dbaf6f2
@marvinkruse
Fix: Resolve versioning issues
76ed2d0 
Known issues:
- Prior versions are currently missing
- Orchestrator in this current form only supports v2 of the payment processors

Both will be fixed in a follow-up PR soon.
@marvinkruse
Merge branch 'dev' into audit-payment-order-struct
e831ef6
@marvinkruse
Copy link
Member

marvinkruse commented Feb 21, 2025

@0xNuggan Resolved the versioning issues. There are a few things missing in general that we do not solve here (i.e. Orchestrator technically now only supports the v2, not v1 anymore, but we will address that in another PR anyways) - all not relevant for the current development and more relevant for deployments etc. which I'll handle.

To get general compatibility I added the PaymentProcessor_v1 and PaymentProcessor_v2 distinction as well as the same of the ERC20 Payment Client and specifically allowed both in the Module_v1.

Also merged the latest dev changes into this. Does that look good to you?

(Pinging @Zitzak for visibility to see this progress - can be merged if @0xNuggan is happy)

@Zitzak
Copy link
Collaborator

Zitzak commented Feb 21, 2025

@marvinkruse thank you for the update. If you haven't already, could you make sure that we have a Linear issue tracking the changes you describe which will be addressed through a different PR. Thank you ser

@0xNuggan 0xNuggan merged commit cd8c1a8 into dev Feb 21, 2025
5 checks passed
@0xNuggan 0xNuggan deleted the audit-payment-order-struct branch February 21, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinkruse marvinkruse marvinkruse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xNuggan @marvinkruse @Zitzak