Merged
Conversation
ColinDKelley
approved these changes
Aug 17, 2020
ColinDKelley
left a comment
ColinDKelley
left a comment
There was a problem hiding this comment.
Looks good! Just a nit suggestion in two places.
|
@jebentier Maybe update the README in the is PR to explicitly mention Rails 4, 5, and 6 are all supported? Possibly the gemspec too? |
Author
|
@ColinDKelley the README and gemspec already restrict to rails 5, which is all we've confirmed in our testing so far. There is a ticket that I've created to add modern unit tests to the project which will include figuring out rails 6 support. |
Add basic automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[0.1.0] - Unreleased
Added