Add developer compare view and readiness fallback#38
Open
KingParmenides wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the compare view + readiness fallback — the UI piece is solid. One ask before PC review: This PR also adds
Option 1 is cleaner. The compare-view feature itself looks ready to merge once decoupled. |
lekanbams
suggested changes
May 12, 2026
Contributor
lekanbams
left a comment
There was a problem hiding this comment.
PC review — lekanbams
Compare-view UI is good work, but blocking on the data-file drift:
- data.json / public/data.json drift: the PR stamps
last_verifiedintopublic/data.jsonwithout touchingdata.json. This is exactly the drift #42 makes un-mergeable downstream. Please rebase on #42 after it lands so the sync constraint is enforced. - Readiness index renderer: tolerating both numeric and structured values is the right defensive move, keep that.
The compare panel itself is clean: up to 4 devs, persists across filters, surfaces rank/score/pq_vol/summary/key_source. That's the review surface PCs need.
Hold and rebase after #42. Ping me when ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.quantum_readiness_indexvalueslast_verifiedfields sonpm run validate:datapasses on current public dataWhy
Issue 1btc-news/news-client#33 lists compare views as visualizer extension work. The current public data exposes
metadata.quantum_readiness_indexas a number, while the frontend expected a structured object; this patch keeps the dashboard rendering and adds a concrete compare workflow for PC/DRI review.Verification
npm run validate:datased -n '/<script>/,/<\\/script>/p' public/index.html | sed '1d;$d' | node --check -\n-git diff --check