Get branch up to speed/upgraded by andersfischernielsen · Pull Request #557 · Islanders-Game/Islanders

andersfischernielsen · 2019-10-14T08:08:42Z

The PR gets the develop branch up to speed:

Merged working master into develop
Updated all package.jsons using yarn upgrade
Made sure all projects still build with upgraded dependencies

andersfischernielsen · 2019-10-14T08:22:41Z

The Sass Loader error seems to be fixable by doing this: vuejs/vue-cli#4513

anders-wind · 2019-10-15T08:14:28Z

There seems to still be a problem with establishing connection between the client and the server. Might be due to updates to sockets?

andersfischernielsen · 2019-10-15T08:19:29Z

Did we upgrade to Socket.IO 2.0? I can't find anything in the dependabot mess..

andersfischernielsen · 2019-10-15T08:21:32Z

Apparently we did. It's 1.4.X on master. Getting really sick of this bot TBH

andersfischernielsen · 2019-10-15T08:22:34Z

Could the connection errors be ID-related? See https://socket.io/blog/socket-io-2-0-0/ && socketio/socket.io-client#1058

andersfischernielsen · 2019-10-15T09:55:34Z

So, it seems that the call at https://github.com/Awia00/Pilgrims/blob/eae3326bf674e51a67f9410f3bdf6dd3ca875409/pilgrims-client/src/store/store.ts#L27 never resolves. I'm unsure what Axios does, but the await never resolves (also not after removing the double await we currently have on develop)

andersfischernielsen · 2019-10-15T10:02:56Z

After more researching, it looks like the mongo DB cannot be reached, that's why the Axiom call waits (tested by running docker run mongo -d and Server+Client using yarn)

anders-wind · 2019-10-15T10:12:25Z

Can you try with docker run -d -p 27017:27017 mongo

anders-wind · 2019-10-15T10:13:13Z

I think the double await is there for a reason (might be something with await for the reply and awaiting the json deserialization)

andersfischernielsen · 2019-10-15T11:36:24Z

For some reason the flatMap function is missing whenever Client receives data from Server. This currently breaks the "Start Game" flow. But the connection is fine.

andersfischernielsen · 2019-10-15T12:30:15Z

Now Client is able to flatMap... Slightly annoying fix, but there's no way to hook into Socket.IO to specify a custom serializer/deserializer AFAIK

anders-wind · 2019-10-15T15:26:31Z

Now Client is able to flatMap... Slightly annoying fix, but there's no way to hook into Socket.IO to specify a custom serializer/deserializer AFAIK

Nice! Its not that ugly, but mostly just super weird that it types as if it exists but does not.

andersfischernielsen · 2019-10-16T07:43:32Z

Yeah, it's super strange. I think the type annotations just override whatever is actually present, which is worrying... 🙁

andersfischernielsen · 2019-10-16T07:48:48Z

I'm getting some weird "PIXI is missing" errors in Client now, but it builds without errors. Strange. Can you reproduce @Awia00?

andersfischernielsen · 2019-10-17T14:09:39Z

Woah, dependabot

…client/develop/vuetify-2.1.17

Bumps [@types/body-parser](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/body-parser) from 1.17.1 to 1.19.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/body-parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…server/develop/types/body-parser-1.19.0

Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.3.14 to 3.3.16. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.7.4 to 3.7.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v3.7.4...v3.7.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [uuid](https://github.com/uuidjs/uuid) from 3.3.3 to 3.4.0. - [Release notes](https://github.com/uuidjs/uuid/releases) - [Changelog](https://github.com/uuidjs/uuid/blob/master/CHANGELOG.md) - [Commits](uuidjs/uuid@v3.3.3...v3.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [@types/uuid](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/uuid) from 3.4.6 to 3.4.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/uuid) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.7.4 to 3.7.5. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v3.7.4...v3.7.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…shared/develop/uuid-3.4.0

…shared/develop/typescript-3.7.5

…client/develop/vue/cli-plugin-babel-4.3.0

Bumps [@vue/cli-plugin-unit-jest](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-unit-jest) from 4.2.3 to 4.3.0. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.0/packages/@vue/cli-plugin-unit-jest) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [@vue/cli-plugin-pwa](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-pwa) from 4.2.3 to 4.3.0. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.0/packages/@vue/cli-plugin-pwa) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-plugin-unit-jest-4.3.0

…client/develop/vue/cli-plugin-pwa-4.3.0

Bumps [@types/mongodb](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mongodb) from 3.5.4 to 3.5.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mongodb) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…server/develop/types/mongodb-3.5.5

Bumps [@vue/cli-service](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-service) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.1/packages/@vue/cli-service) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-service-4.3.1

Bumps [vuetify](https://github.com/vuetifyjs/vuetify/tree/HEAD/packages/vuetify) from 2.2.20 to 2.2.21. - [Release notes](https://github.com/vuetifyjs/vuetify/releases) - [Commits](https://github.com/vuetifyjs/vuetify/commits/v2.2.21/packages/vuetify) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Bumps [@vue/cli-plugin-pwa](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-pwa) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.1/packages/@vue/cli-plugin-pwa) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-plugin-pwa-4.3.1

…client/develop/vuetify-2.2.21

Bumps [@vue/cli-plugin-unit-jest](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-unit-jest) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.1/packages/@vue/cli-plugin-unit-jest) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-plugin-unit-jest-4.3.1

Bumps [@vue/cli-plugin-typescript](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-typescript) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.1/packages/@vue/cli-plugin-typescript) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-plugin-typescript-4.3.1

Bumps [@vue/cli-plugin-babel](https://github.com/vuejs/vue-cli/tree/HEAD/packages/@vue/cli-plugin-babel) from 4.3.0 to 4.3.1. - [Release notes](https://github.com/vuejs/vue-cli/releases) - [Changelog](https://github.com/vuejs/vue-cli/blob/dev/CHANGELOG.md) - [Commits](https://github.com/vuejs/vue-cli/commits/v4.3.1/packages/@vue/cli-plugin-babel) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…client/develop/vue/cli-plugin-babel-4.3.1

Bumps [@types/express](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express) from 4.17.4 to 4.17.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

…server/develop/types/express-4.17.6

anders-wind · 2020-04-12T21:09:58Z

I'm going to merge this into master to try to get it this project moving a bit again :)

andersfischernielsen changed the title ~~Develop~~ Get develop branch working/up to speed Oct 14, 2019

andersfischernielsen changed the title ~~Get develop branch working/up to speed~~ Get branch up to speed/upgraded Oct 14, 2019

andersfischernielsen closed this Oct 14, 2019

andersfischernielsen reopened this Oct 14, 2019

dependabot-preview bot added 11 commits January 2, 2020 04:39

Merge pull request #671 from Awia00/dependabot/npm_and_yarn/pilgrims-…

36fa305

…client/develop/vuetify-2.1.17

Merge pull request #727 from Awia00/dependabot/npm_and_yarn/pilgrims-…

23628a8

…server/develop/types/body-parser-1.19.0

Merge pull request #693 from Awia00/dependabot/npm_and_yarn/pilgrims-…

2c2c6d1

…shared/develop/uuid-3.4.0

Merge pull request #692 from Awia00/dependabot/npm_and_yarn/pilgrims-…

f69866d

…shared/develop/typescript-3.7.5

dependabot-preview bot and others added 25 commits April 6, 2020 04:42

Merge pull request #818 from Awia00/dependabot/npm_and_yarn/pilgrims-…

22e8178

…client/develop/vue/cli-plugin-babel-4.3.0

Merge pull request #821 from Awia00/dependabot/npm_and_yarn/pilgrims-…

d456856

…client/develop/vue/cli-plugin-unit-jest-4.3.0

Merge pull request #820 from Awia00/dependabot/npm_and_yarn/pilgrims-…

40d9936

…client/develop/vue/cli-plugin-pwa-4.3.0

Merge pull request #822 from Awia00/dependabot/npm_and_yarn/pilgrims-…

3cdb742

…server/develop/types/mongodb-3.5.5

Merge pull request #823 from Awia00/dependabot/npm_and_yarn/pilgrims-…

eebde76

…client/develop/vue/cli-service-4.3.1

Merge pull request #828 from Awia00/dependabot/npm_and_yarn/pilgrims-…

1c59bf2

…client/develop/vue/cli-plugin-pwa-4.3.1

Merge pull request #825 from Awia00/dependabot/npm_and_yarn/pilgrims-…

0dfce56

…client/develop/vuetify-2.2.21

Merge pull request #824 from Awia00/dependabot/npm_and_yarn/pilgrims-…

ed35e2d

…client/develop/vue/cli-plugin-unit-jest-4.3.1

Merge pull request #826 from Awia00/dependabot/npm_and_yarn/pilgrims-…

33b97fd

…client/develop/vue/cli-plugin-typescript-4.3.1

Merge pull request #827 from Awia00/dependabot/npm_and_yarn/pilgrims-…

ca1ddab

…client/develop/vue/cli-plugin-babel-4.3.1

Moved the pull request template to github folder

e8429a0

Cleaned up the readme

76968a5

Fixed a few type errors due to updated dependencies

1a667e8

Merge pull request #832 from Awia00/dependabot/npm_and_yarn/pilgrims-…

717d12f

…server/develop/types/express-4.17.6

Fixed tslint errors

d3932d3

anders-wind added 3 commits April 12, 2020 23:21

Removed unused files

c2bac5b

Updated packages for the client and fixed a few lint errors

4419e47

Merge remote-tracking branch 'origin/develop' into develop

f68e40f

anders-wind merged commit 1acac21 into master Apr 12, 2020

Conversation

andersfischernielsen commented Oct 14, 2019

Uh oh!

andersfischernielsen commented Oct 14, 2019

Uh oh!

anders-wind commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andersfischernielsen commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anders-wind commented Oct 15, 2019

Uh oh!

anders-wind commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 15, 2019

Uh oh!

anders-wind commented Oct 15, 2019

Uh oh!

andersfischernielsen commented Oct 16, 2019

Uh oh!

andersfischernielsen commented Oct 16, 2019

Uh oh!

andersfischernielsen commented Oct 17, 2019

Uh oh!

anders-wind commented Apr 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andersfischernielsen commented Oct 15, 2019 •

edited

Loading

andersfischernielsen commented Oct 15, 2019 •

edited

Loading