[SDK-235] Add ability to sync and get messages #797

lposen · 2026-01-11T06:18:26Z

🔹 JIRA Ticket(s) if any

SDK-235

✏️ Description

Add ability to sync messages
Add ability to get messages

Testing

Run the setup
Login and then click on the "Embedded" tab

Click "Sync messages"

In the Xcode Console, you should see something that looks like this:

 💛 17:55:06.1810:0x600001836640:ReactIterableAPI:syncEmbeddedMessages():512
 💚 17:55:06.2020:0x600001836640:Pending:init(value:):199
 💚 17:55:06.2050:0x600001836640:Pending:init(value:):199
 💚 17:55:06.7080:0x60000185fc80:Pending:deinit:215
 💚 17:55:06.7090:0x60000185fc80:Pending:deinit:215

Click "Get messages"
If you have embedded messages which are active, you should see the data for them in the emulator.

Setup

cd into root and run yarn install
cd into example and run yarn install
cd into ios and run bundle exec pod install
open two separate terminals.
In Terminal 1
- run watchman watch-del-all
- run yarn start --reset-cache
In Terminal 2
- cd into ios
- run open ReactNativeSdkExample.xcworkspace
- Once Xcode opens the project, choose an emulator then click the play button to run it.

… synchronization

…ng embedded messages

… and improve message retrieval

github-actions · 2026-01-11T06:19:01Z

Lines	Statements	Branches	Functions
	62.72% (392/625)	38.64% (97/251)	61.5% (139/226)

qltysh · 2026-01-11T06:19:04Z

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copilot

Pull request overview

This PR adds the ability to sync embedded messages and retrieve embedded messages with optional placement ID filtering for the iOS platform. The Android implementation already exists in the codebase.

Changes:

Added iOS native implementation for syncEmbeddedMessages() and getEmbeddedMessages() methods
Added serialization support for IterableEmbeddedMessage to convert to dictionary format
Simplified the example app usage to pass placement IDs directly instead of chaining promises

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
ios/RNIterableAPI/Serialization.swift	Adds `toDict()` extension for `IterableEmbeddedMessage` to serialize messages for React Native
ios/RNIterableAPI/ReactIterableAPI.swift	Implements `syncEmbeddedMessages()` and `getEmbeddedMessages()` methods with placement ID filtering
ios/RNIterableAPI/RNIterableAPI.mm	Exports the new methods for both new and legacy React Native architectures
example/src/components/Embedded/Embedded.tsx	Simplifies the `getEmbeddedMessages` callback to accept placement IDs directly as a parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sumeruchat · 2026-01-13T00:51:03Z

ios/RNIterableAPI/ReactIterableAPI.swift

+  public func syncEmbeddedMessages() {
+    ITBInfo()
+    IterableAPI.embeddedManager.syncMessages { }
+  }


What happens when syncMessages fails.

Unfortunately, it would swallow it. I would love to add success/error callbacks, but unfortunately Android does not seem to expose them, so I would only be able to do so for iOS. As RN needs to have similar capabilities for both, I kind of have to forgo the error handling here as I can't seem to figure it out properly in Android.

@Ayyanchira -- please let me know if I misunderstood this!

sumeruchat · 2026-01-13T00:51:55Z

ios/RNIterableAPI/ReactIterableAPI.swift

+        let placementMessages = IterableAPI.embeddedManager.getMessages(
+          for: placementId.intValue
+        )
+        messages.append(contentsOf: placementMessages)


what if placementMessages is nil

It would return an empty array

sumeruchat · 2026-01-13T00:54:28Z

ios/RNIterableAPI/ReactIterableAPI.swift

+    ITBInfo()
+    var messages: [IterableEmbeddedMessage] = []
+
+    if let placementIds = placementIds, !placementIds.isEmpty {


need a comment here to explain why if placementIds is nil or empty we just do IterableAPI.embeddedManager.getMessages(). Would the messages array be coherent in both cases.

It would be coherent for both. Added a comment regarding this, but not 100% sure if this is what you meant. Please let me know if it is not.

sumeruchat · 2026-01-13T00:59:44Z

ios/RNIterableAPI/Serialization.swift

+    // Serialize metadata (which is Codable)
+    if let metadataDict = SerializationUtil.encodableToDictionary(encodable: metadata) {
+      dict["metadata"] = metadataDict
+    }


What if serialization fails but the metadata is partially encodable.

JSONEnvoder is atomic -- If any property fails to encode, the entire encoding will fail. So there wouldn't be partial encoding. But the entire metadata would be silently omitted.

Updated this so that it would fail if the encoding fails so that the error isn't swallowed.

sumeruchat · 2026-01-13T01:00:09Z

ios/RNIterableAPI/Serialization.swift

+    if let elements = elements,
+       let elementsDict = SerializationUtil.encodableToDictionary(encodable: elements) {
+      dict["elements"] = elementsDict
+    }


What is serialization fails but the elementsDict is partially encodable.

Updated this -- let me know if this works

…trieval from all placements

sumeruchat

LGTM

lposen added 3 commits January 10, 2026 21:56

feat: add syncEmbeddedMessages method to ReactIterableAPI for message…

217b712

… synchronization

feat: add getEmbeddedMessages method to ReactIterableAPI for retrievi…

a5cf683

…ng embedded messages

refactor: update getEmbeddedMessages to accept optional placement IDs…

a9d8198

… and improve message retrieval

lposen added the embedded Issues/PRs related to Embedded Messages label Jan 11, 2026

lposen requested a review from Copilot January 12, 2026 01:29

Copilot started reviewing on behalf of lposen January 12, 2026 01:29 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

sumeruchat reviewed Jan 13, 2026

View reviewed changes

lposen added 2 commits January 12, 2026 18:20

docs: clarify comments in ReactIterableAPI.swift regarding message re…

c15a057

…trieval from all placements

fix: fail if encoding fails instead of silently omitting field

41e080a

sumeruchat approved these changes Jan 13, 2026

View reviewed changes

[SDK-235] Add ability to sync and get messages #797

Are you sure you want to change the base?

[SDK-235] Add ability to sync and get messages #797

Conversation

lposen commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Setup

Uh oh!

github-actions bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sumeruchat left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lposen commented Jan 11, 2026 •

edited

Loading

github-actions bot commented Jan 11, 2026 •

edited

Loading

qltysh bot commented Jan 11, 2026 •

edited

Loading