fix: correct About version number and drag-and-drop file paths#9
Merged
Conversation
- Use env!("CARGO_PKG_VERSION") in AboutMetadata so the version
stays in sync with Cargo.toml automatically
- Replace HTML5 drop handler with tauri://drag-drop event listener;
Tauri v2 webview does not expose file.path on File objects so the
old handler always fell back to the bare filename instead of the
absolute path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AboutMetadatawas hardcoded to1.1.0— now usesenv!("CARGO_PKG_VERSION")so it stays in sync withCargo.tomlautomaticallyfile.pathonFileobjects from the HTML5 drag-and-drop API (an Electron-only property), so the old handler always calledaddPathwith the bare filename instead of the absolute path. Replaced with atauri://drag-dropevent listener which provides the correct absolute paths; HTML5dragover/dragleavekept for visual feedbackTest Plan
npm test— 88 tests pass1.3.0(matchingCargo.toml)🤖 Generated with Claude Code