Feature/gsi validation netcdf #207
Conversation
|
Putting this Draft PR in for initial review. It is still a draft PR as:
Right now inclusion of CRTMv3 with GFSv17 is unlikely given the issues with seg faults. |
|
@ADCollard I was in Italy last week, so just now getting back to this today. |
| (RTV(1)%n_Stokes > 1 .AND. CloudC%N_PHASE_ELEMENTS < 6 )) THEN | ||
| Error_Status = FAILURE | ||
| WRITE( Message,'("N_PHASE_ELEMENTS OF CLOUD LUT NOT RIGHT ",i0)' ) CloudC%N_PHASE_ELEMENTS | ||
| WRITE( Message,'("N_PHASE_ELEMENTS OF CLOUD LUT NOT RIGHT ",i0)' ) CloudC%N_PHASE_ELEMENTS, AeroC%N_PHASE_ELEMENTS, RTV(1)%n_Stokes |
There was a problem hiding this comment.
It makes sense to add RTV(1)%n_Stokes, but there is no need to print AeroC%N_PHASE_ELEMENTS here.
| (RTV(1)%n_Stokes > 1 .AND. AeroC%N_PHASE_ELEMENTS < 6 )) THEN | ||
| Error_Status = FAILURE | ||
| WRITE( Message,'("N_PHASE_ELEMENTS OF AEROSOL LUT NOT RIGHT ",i0)' ) AeroC%N_PHASE_ELEMENTS | ||
| WRITE( Message,'("N_PHASE_ELEMENTS OF AEROSOL LUT NOT RIGHT ",i0)' ) AeroC%N_PHASE_ELEMENTS, AeroC%N_PHASE_ELEMENTS, RTV(1)%n_Stokes |
There was a problem hiding this comment.
Same here. It makes sense to add RTV(1)%n_Stokes, but there is no need to print CloudC%N_PHASE_ELEMENTS here. (AeroC%N_PHASE_ELEMENTS is added twice, likely a typo)
The IF statement at line 618 makes sure CloudC%N_PHASE_ELEMENTS == AeroC%N_PHASE_ELEMENTS if they are both loaded.
| ! ...Default filenames | ||
| Default_Aerosol_Model = 'CRTM' | ||
| Default_AerosolCoeff_File = 'AerosolCoeff.bin' | ||
| Default_AerosolCoeff_File = 'AerosolCoeff.nc' |
There was a problem hiding this comment.
Haven't tested this branch yet, waiting for fix folder updates on coefficient filenames (nc4 --> nc)
There was a problem hiding this comment.
@chengdang working on it now -- not ready yet, so ignore pushes to this PR until I've given the thumbs up.
Description
Changes required to use netCDF files by default. Added missing routines for antenna correction coefficients.
Issue(s) addressed
Partially Resolves #192
Dependencies
None
Impact
Expected impact on downstream repositories: None
Checklist