[release/2.0] Fix MET segfaults (fixup_rpath --> environment modification) #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use LD_LIBRARY_PATH environment modifications instead
11 tasks
55 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
areinecke and
rickgrubin-noaa
areinecke
approved these changes
Dec 11, 2025
rickgrubin-noaa
approved these changes
Dec 11, 2025
github-project-automation
bot
moved this from In Progress
to Done
in spack-stack-2.0.x (2025 Q4)
rickgrubin-noaa
pushed a commit
to rickgrubin-noaa/spack-packages
that referenced
this pull request
Dec 29, 2025
So that I can point to this when people ask why the repository is structured this way. Signed-off-by: Todd Gamblin <tgamblin@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix MET segmentation faults reported in JCSDA/spack-stack#1839 by removing the
fixup_rpathlogic for the Python libraries and replacing it with an environment modification (LD_LIBRARY_PATH). In the case that the spack module logic also handlesLD_LIBRARY_PATH(which it usually doesn't these days), then this may be redundant, but it won't hurt.Note that the
fixup_rpathlogic is not in the upstream spack repository, hence no PR is required at this time.This PR is for
release/2.0and will be merged back tospack-stack-devafterwards.Testing
See JCSDA/spack-stack#1844
Note that the first attempt failed in the
create envstep during theldd_check.pycall. But the build of the MET package succeeded, and I verified that the segfaults are gone on the two platforms Atlantis and Nautilus with all compilers.Issues
Working toward JCSDA/spack-stack#1839