Update project_charter/documentation, update util/check_package_config.py, remove upp from unified-dev#1022
Merged
climbfuji merged 11 commits intoJCSDA:developfrom Mar 11, 2024
Conversation
…_config.py: import yaml from spack _vendored, catch non-existent variants
…ainers and install responsibilities
climbfuji
added
INFRA
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
2 times, most recently
from
187d2f4 to
ef5bbfa
Compare
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
from
ef5bbfa to
abb3a4e
Compare
…eature/update_check_package_config_and_remove_upp
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
7 times, most recently
from
fd7472e to
6d3c791
Compare
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
from
6d3c791 to
2ae50c5
Compare
climbfuji
commented
Mar 8, 2024
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA,
edwardhartnett and
ulmononian
RatkoVasic-NOAA
approved these changes
Mar 8, 2024
Collaborator
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me.
…eature/update_check_package_config_and_remove_upp
edwardhartnett
approved these changes
Mar 11, 2024
climbfuji
deleted the
feature/update_check_package_config_and_remove_upp
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.md,project_charter.mdand documentation with new maintainers and install responsibilitiesuppfromufs-srw-app-envvirtual package and clean upunified-devtemplateutil/check_package_config.py: import yaml from spack _vendored, catch non-existent variants, test on macOSutil/ldd_check.pyand documentation - this tool only works on LinuxTesting
Applications affected
UFS SRW App - check if standalone
uppis really not requiredSystems affected
None
Dependencies
None
Issue(s) addressed
Resolves #825
Resolves #898
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.