release/1.6.0: bugfix - repair dockerfile template#387
Merged
climbfuji merged 1 commit intoJCSDA:release/1.6.0from Jan 4, 2024
Merged
Conversation
…ions for build and final phase back in
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA and
ulmononian
AlexanderRichert-NOAA
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recent update of our spack fork from spack develop removed important pieces of the Dockerfile template, which broke our containers (we didn't notice, because we only build them but don't run anything in them in CI).
This PR puts the two pieces of code back. I tested this with the spack-stack-1.6.0 release code and the containers are good again.
Issue(s) addressed
Containers no longer functional since nov2023_spackmerge
Dependencies
n/a
Impact
n/a
Checklist
I have made corresponding changes to the documentationunittests before creating the PR