Bug fix for py-jupyter-server and hidden npm/node dependency#417
Merged
climbfuji merged 4 commits intoJCSDA:jcsda_emc_spack_stackfrom Mar 20, 2024
Merged
Conversation
…npm/node. Patch the build system for ~typescript so that it doesn't find any npm/node installations and attempts to build the typescript extension even though it shouldn't
climbfuji
force-pushed
the
bugfix/py_jupyter_server_npm_node
branch
from
869302e to
ca02e13
Compare
4 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA,
sking112 and
srherbener
srherbener
approved these changes
Mar 20, 2024
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
This change works on my Mac! Thanks for fixing this.
RatkoVasic-NOAA
approved these changes
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add variant typescript for
py-jupyter-server@:1, which then requiresnpm/node. Patch the build system for~typescriptso that it doesn't autodetect any systemnpm/nodeinstallations. That is because if it does findnpmsomewhere in the path, it attempts to build the typescript extension even though it shouldn't, and this can cause problems as described in JCSDA/spack-stack#995, JCSDA/spack-stack#928, and spack#41899.Note that the build backend has changed from
py-packagingtopy-hatchbetweenpy-jupyter-serverversions 1 and 2, therefore this bug fix is restricted to version 1.Corresponding spack develop PR: spack#43279 (merged 2024/03/20)
Testing
I tested installing
py-jupyter-server@1.21.1on my macOS with a broken localnpm/nodeinstallation (to mimick the problem described in JCSDA/spack-stack#995. I was able to install it successfully with the default variant~typescript, and also with+typescript(which addednpmandnodeas dependencies).It also fixed the problem on Narwhal with the existing but broken
npm/nodeinstallation.Also testing default
~typescriptin JCSDA/spack-stack#1033Issue(s) addressed
Resolves JCSDA/spack-stack#995
Resolves JCSDA/spack-stack#928
Dependencies
n/a
Impact
n/a
Checklist