-
Notifications
You must be signed in to change notification settings - Fork 16
Update met and metplus new versions. #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
does this build with the release/1.0.0 branch of spack-stack? |
Did I miss something? |
OK, maybe you meant 2.0.0 :-) IDK, probably. I build only with 1.9.0 (tag 1.9.2). |
|
You just answered. Ok, if spack-stack release/1.9.0 works with this branch (I was worried about the new language dependencies), then ok. |
|
I'll correct myself. I tested with old package.py's, just with added new versions for met and metplus. I just added new changes which are currently in develop. I will test with new package.py's before I create PR for spack-stack/1.9.0 |
|
@climbfuji tested, all OK. |
|
Perfect, thanks! I'll merge this, then I can tag spack and take care of the submodule pointer update in spack-stack in my currently open draft PR. Just to confirm, these are additional versions that do not replace the default met/metplus versions, correct? In other words, they will go into an addon environment? |
No addons, they will replace old versions. Nobody is using old ones. |
|
@climbfuji actually, you don't need to update spack pointer, I just did that. My spack-stack PR is ready. |
|
I don't see the PR yet? |
|
I'm finishing description. |
Update met and metplus package.py files.