Skip to content

Conversation

@RatkoVasic-NOAA
Copy link
Collaborator

Update met and metplus package.py files.

@climbfuji
Copy link
Collaborator

does this build with the release/1.0.0 branch of spack-stack?

@RatkoVasic-NOAA
Copy link
Collaborator Author

does this build with the release/1.0.0 branch of spack-stack?

Did I miss something?

@RatkoVasic-NOAA
Copy link
Collaborator Author

does this build with the release/1.0.0 branch of spack-stack?

OK, maybe you meant 2.0.0 :-) IDK, probably. I build only with 1.9.0 (tag 1.9.2).

@climbfuji
Copy link
Collaborator

You just answered. Ok, if spack-stack release/1.9.0 works with this branch (I was worried about the new language dependencies), then ok.

@RatkoVasic-NOAA
Copy link
Collaborator Author

I'll correct myself. I tested with old package.py's, just with added new versions for met and metplus. I just added new changes which are currently in develop. I will test with new package.py's before I create PR for spack-stack/1.9.0

@RatkoVasic-NOAA
Copy link
Collaborator Author

@climbfuji tested, all OK.

@climbfuji
Copy link
Collaborator

Perfect, thanks! I'll merge this, then I can tag spack and take care of the submodule pointer update in spack-stack in my currently open draft PR.

Just to confirm, these are additional versions that do not replace the default met/metplus versions, correct? In other words, they will go into an addon environment?

@climbfuji climbfuji self-requested a review August 22, 2025 18:02
@climbfuji climbfuji merged commit edd09cd into JCSDA:release/1.9.0 Aug 22, 2025
14 of 15 checks passed
@RatkoVasic-NOAA
Copy link
Collaborator Author

Just to confirm, these are additional versions that do not replace the default met/metplus versions, correct? In other words, they will go into an addon environment?

No addons, they will replace old versions. Nobody is using old ones.
So, if you are going to update pointer to spack, then I'll just create PR for spack-stack configs/common/packages.yaml file.

@RatkoVasic-NOAA
Copy link
Collaborator Author

@climbfuji actually, you don't need to update spack pointer, I just did that. My spack-stack PR is ready.

@climbfuji
Copy link
Collaborator

I don't see the PR yet?

@RatkoVasic-NOAA
Copy link
Collaborator Author

I'm finishing description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants