Update to ufs-bundle CMakeLists.txt to use same RPATH and ecbundle_initialize commands that jedi-bundle uses #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng RPATH, replacing ufs-bundle cmake prefix material.
Collaborator
|
CI failed in S2S build, but the error doesn't seem to be related to this PR? https://github.com/JCSDA/ufs-bundle/actions/runs/10151281420/job/28070209562?pr=71 |
climbfuji
requested changes
Jul 30, 2024
CMakeLists.txt
Outdated
| if(APPLE) | ||
| list( APPEND CMAKE_INSTALL_RPATH $ENV{llvm_openmp_ROOT}/lib ) | ||
| endif() | ||
| list( APPEND CMAKE_INSTALL_RPATH ${CMAKE_CURRENT_BINARY_DIR}/fv3 ) |
Collaborator
There was a problem hiding this comment.
This line should be removed. There is no subdirectory fv3 in the top-level ufs-bundle
Author
|
I'm on PTO until Friday, Aug 2. Please feel free to modify this PR as needed. |
Collaborator
Same for me :-) |
removed a space Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
removed append of RPATH with fv3 directory
Collaborator
|
I won't have time to work on this unfortunately; I'll remove myself from the reviewers here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per issue: #49
I blindly copied over jedi-bundle CMakeLists.txt front material regarding RPATH, replacing ufs-bundle cmake prefix material.
This adds RPATH information used in jedi-bundle, which appears to fix the CRTM not being found problem. This was only tested on S4.
Issue(s) addressed
Resolves #49
Checklist