Re-scale TRN HYPERPOLARIZATION_STEPS to physiological depths (#370)#371
Merged
Conversation
The TRN HYPERPOLARIZATION_STEPS band (-5.0 to -1.0 uA/cm2, 1.0 step) drove Vm to ~-136 mV on the deepest sweep, a supra-physiological regime that maximally de-inactivates ICaT and Ih. Re-scale to -2.0 to -0.4 uA/cm2 (0.4 step) so the deepest sweep parks Vm near -106 mV, a realistic post-inhibitory rebound depth, while preserving the HP92 5-15 spike rebound phenotype. Update the documented Ca range to ~6-18 uM to match the rescaled protocol.
Change the hardcoded single-sweep rebound amplitude from -4.0 to -2.0 uA/cm2 (which hit the same supra-physiological -127 mV depth), update the multi-sweep test docstring/comments to the new -2.0 to -1.2 uA/cm2 sweeps, and tighten the post-release spike upper bound from 35 to 20 to pin the now-physiological HP92 5-15 phenotype.
Keep the trn_intra_burst_ap_result fixture in lockstep with test_trn_step_release_produces_hp92_rebound_burst so the AP-shape assertions apply to the same physiologically-depthed rebound burst.
Update docstring/comment current-value references to the new -2.0 to -1.2 uA/cm2 sweeps and tighten the post-release spike upper bound 35->20 to match the physiological HP92 phenotype. The protocol is built via build_protocol_from_preset so it picks up the rescaled preset override automatically.
Align the analyze_bursts rebound-burst selection filter (5-35 -> 5-20 spikes) and the frequency-assertion wording with the post_release_rebound count assertions tightened earlier, so the file is internally consistent at the new physiological HP band.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROTOCOL_ADJUSTMENTS[HYPERPOLARIZATION_STEPS]band from-5.0 → -1.0 µA/cm²(1.0 step) to-2.0 → -0.4 µA/cm²(0.4 step). The old band drove Vm to ~-136 mV on the deepest sweep — a supra-physiological regime that maximally de-inactivates ICaT and Ih. The new band still produces 5 sweeps, with the deepest landing Vm near -106 mV, a realistic post-inhibitory rebound depth (Huguenard & Prince 1992).8–18 µM→~6–18 µM) to match the rescaled protocol.current_amplitude=-4.0→-2.0) intest_burst_metrics_simulation.pyand thetrn_intra_burst_ap_resultfixture intest_trn.py, which hit the same -127 mV artifact.The HP92 5–15 spike rebound phenotype is preserved on the three asserted deeper sweeps (15/15/11 spikes at 392/439/430 Hz; deepest sweep Vm min = -106.2 mV).
Test plan
-2.0 µA/cm²step release still fires the HP92 5–15 spike LTS reboundCloses #370