Fix launched vessel not getting tracked when it has more freezer parts than another existing vessel#72
Merged
Merged
Conversation
…s than another existing vessel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before that: if you have a previous vessel with N freezer parts, any new vessel you launch having more than N parts will not be tracked (freezing its kerbals will lose them).
(Because UpdatePredictedVesselEC is called for previous vessels, but it iterated with the wrong counter (looping on N parts with max index M-1). This leads to an exception, preventing the huge CheckVslUpdate from completing and adding the new vessel).