Skip to content

Fix quoting issue on generate sql statements #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcelEeken wants to merge 1 commit into from
Closed

Fix quoting issue on generate sql statements #1395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jsonapi/active_relation_resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,7 +845,7 @@ def alias_table_field(table, field, quoted = false)
end

def quote(field)
"\"#{field.to_s}\""
ActiveRecord::Base.connection.quote_table_name(field)
Copy link
Collaborator

@bf4 bf4 Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you write a test for this?

Copy link
Contributor Author

@MarcelEeken MarcelEeken Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an existing open mr that added mysql to the CI workflow. That was opened to cover the same case as this fix.

Would that mr be enough of a test-case
https://github.com/cerebris/jsonapi-resources/pull/1370

end

def apply_filters(records, filters, options = {})
Expand Down