fix: test the adapter-specific query ordering#1402
Merged
Conversation
50b1030 to
0b3852f
Compare
c1189ca to
6186618
Compare
bf4
commented
Mar 10, 2023
| pg = ENV['DATABASE_URL'].starts_with?('postgres') | ||
|
|
||
| if is_db?(:mysql) | ||
| skip "#{adapter_name} test expectations differ in insignificant ways from expected" |
lgebhardt
pushed a commit
that referenced
this pull request
Sep 19, 2023
* fix: test the adapter-specific query ordering * test: make order independent * test: sort order-dependent response * test: skip failing mysql tests as ok for now
lgebhardt
pushed a commit
that referenced
this pull request
Apr 18, 2024
* fix: test the adapter-specific query ordering * test: make order independent * test: sort order-dependent response * test: skip failing mysql tests as ok for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from https://github.com/cerebris/jsonapi-resources/pull/1400
Two tests related to this are still broken on MySQL