fix: qualify Rails as ::Rails to avoid namespace clashes with other gems#1414
fix: qualify Rails as ::Rails to avoid namespace clashes with other gems#1414SingleShot wants to merge 1 commit intoJSONAPI-Resources:masterfrom
Conversation
|
Thanks @SingleShot! What version of JR are you using. Right now we have multiple versions of the gem backed by different branches. The master branch is currently being used for development of the new v0.11 branch, though the current beta of that is on the v0-11-dev branch which will eventually merge to master. I can take this change to the version you are using and get a release out for you. |
|
Hi. I tried integrating both |
| require 'jsonapi/response_document' | ||
| require 'jsonapi/acts_as_resource_controller' | ||
| if Rails::VERSION::MAJOR >= 6 | ||
| if ::Rails::VERSION::MAJOR >= 6 |
There was a problem hiding this comment.
Did this issue come up in response to an experience failure? This specific changes and others in the PR shouldn't be needed, I wouldn't think.
There was a problem hiding this comment.
I thought my issue was linked here but I'm not finding it. Here it is. Basically there is a namespace clash when using this project and a different JSON:API project together.
|
I added this in #1421 and it will go into the master branch when we merge in the v0.11 dev branch |
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
I was unable to get the bug template to run and could not find instructions on how to do so.
Reviewer Checklist: