Make SortedSet for identity arrays optional#1427
Merged
Conversation
bf4
reviewed
Jan 11, 2024
bf4
reviewed
Jan 11, 2024
bf4
reviewed
Jan 11, 2024
bf4
reviewed
Jan 11, 2024
lgebhardt
added a commit
that referenced
this pull request
Apr 18, 2024
* Make SortedSet for identity arrays optional * Fix tests to use sort_related_identities_by_primary_key option override * Keep SortedSet as a development dependency, unless required * Remove sorted_set dependency * Add better messaging about using SortedSet * Clarify setting sort_criteria for includes vs. related resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores SortedSet as an option.
Removes default sorting for includes. Because of how included resources are collected the database sort doesn't actually produce properly sorted results, but does slow the queries.
Fixes
connect_source_identityoption when callingfind_related_fragments_from_inversefor polymorphic relationship routesAll Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: