Store the resource_klass and id in an array for efficiency#1428
Merged
Store the resource_klass and id in an array for efficiency#1428
Conversation
Removes the need to allocate a new array for every comparison
bf4
reviewed
Jan 12, 2024
| @identity_parts.hash | ||
| end | ||
|
|
||
| def <=>(other_identity) |
Collaborator
There was a problem hiding this comment.
Interesting that eql? and <=> diverge in what they compare but is out of scope to this change
Contributor
Author
There was a problem hiding this comment.
For <=> it really should be comparing the resource_klasses first and then the ids second to determine the response. I think that would only affect the ordering of identities in the related identities when we're using a SortedSet and storing identities for a polymorphic relationship. It looks like that comparison can be done without any allocations so it's probably a good idea to make the change, but I'll handle that in a separate PR.
lgebhardt
added a commit
that referenced
this pull request
Apr 18, 2024
Removes the need to allocate a new array for every comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need to allocate a new array for every comparison.
Found a large number of allocations in the
hashmethod when profiling the code. This removes about 35K allocations from a result set that contained about 3500 resources (1000 primary with 2500 includes). Not surprisingly that doesn't actually make a statistically significant performance issue for small requests like the one tested, but every little bit helps.Also changes the
eql?to use thehashmethodAll Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: