fix: add railtie to clear caches when code reloads#1448
Merged
bf4 merged 1 commit intoJSONAPI-Resources:v0-11-devfrom Feb 8, 2024
Merged
fix: add railtie to clear caches when code reloads#1448bf4 merged 1 commit intoJSONAPI-Resources:v0-11-devfrom
bf4 merged 1 commit intoJSONAPI-Resources:v0-11-devfrom
Conversation
4cb43d9 to
8c8fd2a
Compare
bf4
reviewed
Feb 8, 2024
| 'by setting `warn_on_eager_loading_disabled` to false.' | ||
| end | ||
| end | ||
| config.to_prepare do |
Collaborator
There was a problem hiding this comment.
noting that this is related to the same issue we were trying to address in https://github.com/cerebris/jsonapi-resources/pull/1440 and https://github.com/cerebris/jsonapi-resources/pull/1434
Contributor
|
Thanks @adamkiczula! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1439
This adds a railtie hook to clean up the
JSONAPI::Resourcecaches when code reloads so that we don't have stale references to classes lying around.I'm not sure how to test this one in a test suite, but there's a reproduction script in #1439 that passes with this.
All Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: