Warn on missing inverse relationships#1451
Merged
Conversation
867cb47 to
26f9502
Compare
bf4
approved these changes
Apr 17, 2024
Collaborator
bf4
left a comment
There was a problem hiding this comment.
I like it. I think the better naming of source relationship -> inverse relationship will drive better behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds method to the Relationship class to get the inverse_relationship. This supports warning once when the inverse can't be found. This is controllable with a configuration setting and is true by default.
It also adds an option to raise an exception if the inverse can't be found. This is false by default. In this default case if the inverse relationship is missing related resources will not collected or counted.
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: