Merged
Conversation
Removing AR specific code from Resource and moving to new RecordAccessor class.
3007558 to
837b562
Compare
dgeb
approved these changes
Feb 10, 2017
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JR has gradually grown so Resources were very ActiveRecord dependent, making the project difficult to use with no-sql and poro based models. This PR should fix this in a mostly backwards compatible way.
A
RecordAccessorclass for ActiveRecord was created, namedActiveRecordAccessor. This provides support for ActiveRecord along with caching. The goal was to keep backwards compatibility with existing resources. In order to achieve that goal methods which were previously documented as overridable are check to see if they are on the model and called instead of the Accessor method. It is probable/possible that some projects are overriding additional methods and this change will break code.This change should pave the way for supporting models based on POROs and other database systems like MongoDB.
Breaking changes:
RecordAccessor.