Skip to content

Add C++ SDK for Nado Protocol#1

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
jules/cpp-sdk
Draft

Add C++ SDK for Nado Protocol#1
google-labs-jules[bot] wants to merge 1 commit intomainfrom
jules/cpp-sdk

Conversation

@google-labs-jules
Copy link
Copy Markdown

This PR introduces a C++ SDK for the Nado Protocol. It provides:

  1. Keccak-256 Implementation: A standalone implementation of the Keccak-256 hash function (compatible with Ethereum) to replace standard SHA3-256 which differs in padding.
  2. EIP-712 Support: Classes to encode and hash Nado protocol structures (Order, CancelOrders, WithdrawCollateral) according to the EIP-712 standard.
  3. Signing: A helper to sign digests using OpenSSL's ECDSA, demonstrating the full signing flow.
  4. Tests: A nado_sdk_test executable that verifies the generated hashes match expected values (verified against the Python SDK during development).

The SDK is located in the cpp_sdk directory and includes build instructions.


PR created automatically by Jules for task 3074775417443523001 started by @JUN-666

- Implemented RFC-compliant Keccak-256 (Ethereum version)
- Implemented EIP-712 typed data hashing for Nado types (Order, CancelOrders, WithdrawCollateral)
- Added ECDSA signing utility using OpenSSL
- Added CMake build system and Makefile
- Added usage documentation in cpp_sdk/README.md
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants