#2 레시피관리#10
Merged
LeeGukgeon merged 1 commit intodevelopfrom Dec 12, 2024
Merged
Conversation
한 일 : 1. cooking_source -> recipe_source 로 일괄 변경. 2. 생성용 Category, Repository, Request, 추가 3. 읽기 용 Repository, response 추가 4. UserDummyRepository 생성 5. 임시 recipe_source_type, recipe_source_category 추가 문제점 : 1. recipe에 recipe 적을 란이 없다. 2. RecipeCreateTime이 저장되는데 format을 안된다. 해야할 일 : 1. 문제점 수정 2. UD 생성
MinFe4990
requested review from
KIM9909,
LeeGukgeon,
kingkang85,
uni-zun and
yunjaeeun
KIM9909
reviewed
Dec 11, 2024
Contributor
KIM9909
left a comment
KIM9909
left a comment
There was a problem hiding this comment.
변수명 통일이 잘 된 것 같고, 각각 기능 구현을 잘 하신 것 같습니다 !
kingkang85
reviewed
Dec 12, 2024
Contributor
kingkang85
left a comment
kingkang85
left a comment
There was a problem hiding this comment.
생성 날짜가 문자열에서 LocalDateTime으로 발전된 부분 좋은 것 같습니당🤓
Contributor
|
develop에는 완성된 기능만 합치는게 좋을거같습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용 1211
📝 문제점
📝작업할 내용