Conversation
한 일 : 1. cooking_source -> recipe_source 로 일괄 변경. 2. 생성용 Category, Repository, Request, 추가 3. 읽기 용 Repository, response 추가 4. UserDummyRepository 생성 5. 임시 recipe_source_type, recipe_source_category 추가 문제점 : 1. recipe에 recipe 적을 란이 없다. 2. RecipeCreateTime이 저장되는데 format을 안된다. 해야할 일 : 1. 문제점 수정 2. UD 생성
MinFe4990
requested review from
KIM9909,
LeeGukgeon,
kingkang85,
uni-zun and
yunjaeeun
KIM9909
reviewed
Dec 12, 2024
Contributor
KIM9909
left a comment
KIM9909
left a comment
There was a problem hiding this comment.
신기한 어노테이션들이 많네요
CreationTimeStamp랑 UpdateTimeStamp는 자동으로 시간 생성해주는건가요 ?
kingkang85
reviewed
Dec 12, 2024
Contributor
kingkang85
left a comment
kingkang85
left a comment
There was a problem hiding this comment.
기능들 뚝딱뚝딱 잘 구현하시네요..! 짱👍🏻
Contributor
Author
넴, 이제 가능합니다. |
LeeGukgeon
reviewed
Dec 12, 2024
Contributor
LeeGukgeon
left a comment
LeeGukgeon
left a comment
There was a problem hiding this comment.
ERD Cloud 에서부터 tbl_recipe에 recipe 텍스트를 적을 곳이 없었네요 추가해야 될까요?
uni-zun
reviewed
Dec 12, 2024
Contributor
uni-zun
left a comment
uni-zun
left a comment
There was a problem hiding this comment.
레시피 수정 함수의 조건문들이 인상깊네요 !
Contributor
|
상황에 맞는 상태코드도 반환되면 좋을 것 같아요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용 1211
📝 문제점
(기존)
(새로운 문제점)
없음. 앞서 말한 문제 해결해야 나머지 진행 가능.
해야할 일 :
📝작업할 내용
관련 사진
1번 삭제 및 2번 수정한 파일(이름 변경) test1->test1_change