Conversation
Contributor
KIM9909
commented
Dec 12, 2024
KIM9909
commented
- IngredientResponse에 불필요한 생성자 제거
- tbl_ingredient_category와 tbl_ingredient_storage에 카테고리와 보관방법 SQL로 몇 가지 INSERT
- 재료명 조회 시 category_pk, storage_pk가 아닌 카테고리명과 보관방법명이 나오도록 수정
- 재료 수정 기능 구현
- 재료 삭제 기능 구현 -> ingredientManagementPk 를 url에 추가 입력하면 삭제 가능
1. IngredientResponse에 불필요한 생성자 제거 2. tbl_ingredient_category와 tbl_ingredient_storage에 카테고리와 보관방법 SQL로 몇 가지 INSERT 3. 재료명 조회 시 category_pk, storage_pk가 아닌 카테고리명과 보관방법명이 나오도록 수정 4. 재료 수정 기능 구현 5. 재료 삭제 기능 구현 -> ingredientManagementPk 를 url에 추가 입력하면 삭제 가능
MinFe4990
reviewed
Dec 12, 2024
Contributor
There was a problem hiding this comment.
check!
lombok 쓰는데 클래스 생성자를 넣은 이유가 있을까유?
kingkang85
reviewed
Dec 12, 2024
Contributor
kingkang85
left a comment
kingkang85
left a comment
There was a problem hiding this comment.
예외 처리까지 확실하게 해주셨군요. 굿
LeeGukgeon
reviewed
Dec 12, 2024
Contributor
LeeGukgeon
left a comment
LeeGukgeon
left a comment
There was a problem hiding this comment.
재료 수정 , 삭제 기능 구현 확인했습니다
Contributor
|
업데이트할 요소중에 몇가지를 보내지 않아도 의도한대로 업데이트가 되나요? + 충돌 해결도 하셔야 될거같습니다 :) |
Contributor
Author
PUT 요청으로 보낼 때 한가지 필드를 누락해서 보내면 해당 필드의 값이 int인 경우 0, String인 경우 null로 바뀝니다.
|
yunjaeeun
added a commit
that referenced
this pull request
Dec 16, 2024
1. 남은 유통기한 알람 세팅 - 서비스 기능 구현중 - 기능구현 후 로그인에서 비즈니스 로직 이어가도록 수정 Related to: #17
yunjaeeun
added a commit
that referenced
this pull request
Dec 16, 2024
1. 남은 유통기한 알람 구현 완료 유통기한이 7일, 3일 남은 상품에 대해서 알람 발송 2. 로그인 시 작동되도록 수정 필요 Related to: #17
kingkang85
added a commit
that referenced
this pull request
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.