Conversation
kingkang85
requested review from
KIM9909,
LeeGukgeon,
MinFe4990,
uni-zun and
yunjaeeun
Contributor
Author
|
아마 홍범님 것 merge한 후에 제 것 merge하면 SecurityConfig.java에서 충돌날 것 같은데, 마지막에 merge 하시는 분 제 코드를 선택해 주시면 됩니다..! 아님 말고용😵💫 |
MinFe4990
reviewed
Dec 13, 2024
Contributor
MinFe4990
left a comment
MinFe4990
left a comment
There was a problem hiding this comment.
Check!
@yunjaeeun 이 말한대로 /**로 수정해주셨네요!
Contributor
|
수고하셨습니다 개발 마무리 단계에 다같이 권한 관련해서 이야기 나눠보면 좋을 것 같네요 |
KIM9909
reviewed
Dec 13, 2024
Contributor
KIM9909
left a comment
KIM9909
left a comment
There was a problem hiding this comment.
Security url 허용 부분과 회원가입 로직이 잘 작성된 것 같습니다 ! 굿굿
Conflict 발생해도 쉽게 해결할 수 있는 부분 같습니다
LeeGukgeon
reviewed
Dec 13, 2024
Contributor
LeeGukgeon
left a comment
LeeGukgeon
left a comment
There was a problem hiding this comment.
일단 인증 없이도 모든 경로로의 요청을 처리하기 위해서 config를 수정한 점 확인했습니다
uni-zun
added a commit
that referenced
this pull request
Dec 16, 2024
1. 레시피에 필요한 전체 재료도 가져옴 2. 필수재료 인지는 boolean 으로 구별 Related to : #19-2
uni-zun
added a commit
that referenced
this pull request
Dec 22, 2024
1. img 쓰기 위한 약간의 수정 Resolved : #19
uni-zun
added a commit
that referenced
this pull request
Dec 22, 2024
uni-zun
added a commit
that referenced
this pull request
Dec 24, 2024
1. 레시피 추천과 마찬가지의 작업함 Resolved #19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
SecurityConfig 수정
회원가입 기능 구현
예외 처리
스크린샷 (선택)