Conversation
LeeGukgeon
reviewed
Dec 11, 2024
Contributor
LeeGukgeon
left a comment
There was a problem hiding this comment.
mapper를 활용한 재료 조회 메서드를 깔끔하게 구현한 것 같습니다
kingkang85
reviewed
Dec 11, 2024
Contributor
kingkang85
left a comment
There was a problem hiding this comment.
dto와 service 계층이 잘 분리되어 있고, ModelMapper를 사용해 엔티티와 dto 간 변환을 잘 처리해준 것 같습니다!
Contributor
|
흠 잡을게 없네요. |
Contributor
|
재료 조회할 떄 카테고리도 같이 줘야될거같아요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IngredientResponse 클래스를 만들어 Entity와 DB가 매핑되는 객체로 유지될 수 있도록 계층분리를 해주었습니다.
IngredientService인터페이스에 조회 메서드를 만들어 주어서 함께 ServiceImpl에 상속될 수 있도록 하였습니다.