Change delimiter of csv from ; to ,#10190
Closed
northword wants to merge 4 commits intoJabRef:mainfrom
northword:csv-delimiter-comma
Closed
Change delimiter of csv from ; to ,#10190northword wants to merge 4 commits intoJabRef:mainfrom northword:csv-delimiter-comma
; to ,#10190northword wants to merge 4 commits intoJabRef:mainfrom
northword:csv-delimiter-comma
Conversation
Member
|
Please have a look at the failing tests, its seems there are still some test files that need to be converted |
Author
|
@Siedlerchr done, please review again, thanks! |
Member
|
Codewise looks good, probably missing a changelog entry yet. Please add a short one. |
Author
|
@calixtus A short description of the change has been added to CHANGELOG.md under the subsection "Change", and pr has been rebased to the latest main branch. |
Member
|
I would propose we wait with merge this one after the release of 5.10 as this includes potential breaking changes. Users who have their own custom journal abbrevs would need to convert their files as well |
6 tasks
Member
|
Superseeded by #10281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change delimiter of csv from
;to,Fixes JabRef/abbrv.jabref.org#130
Refs JabRef/abbrv.jabref.org#139
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)