Fix architecture gui/logic by koppor · Pull Request #11729 · JabRef/jabref

koppor · 2024-09-08T17:05:53Z

This prepares #110

This is based on #11728 - thus, the first commits are doubled. With some "git magic" they, don't appear in the diff.

Contributes to https://github.com/JabRef/jabref-issue-melting-pot/issues/440

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Co-authored-by: Christoph <siedlerkiller@gmail.com>

# Conflicts: # src/main/java/org/jabref/gui/LibraryTab.java

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Also: - Move openAiChat from AiService (logic) to GroupTree (gui)

github-actions

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

# Conflicts: # src/main/java/org/jabref/gui/ai/components/privacynotice/PrivacyNoticeComponent.java

# Conflicts: # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

Siedlerchr · 2024-09-14T16:16:08Z

Server(Test) still has a dependency on gui prefs

…xportFormatTestOnlyRequiredFields.xml

…xportFormatTestAllFields.xml

github-actions · 2024-09-15T00:22:52Z

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Siedlerchr · 2024-09-15T08:55:54Z

Tested locally, seems to work fine so far

koppor and others added 17 commits September 8, 2024 11:45

Refine JavaDoc

201a708

Add TODOs

86eea9b

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Fix typos

fa6c90e

Reoder settings

b1cd984

Fix arch flaw

1d38f85

Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Fix checkstyle and formatting

6396090

Make BackgroundTask independent from UI

11ca072

Move BackgroundTask from gui to logic

071e302

Co-authored-by: Christoph <siedlerkiller@gmail.com>

protected -> public

24a34ae

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Move CurrentThreadTaskExecutor from gui to logic

cdeaa5f

Co-authored-by: Christoph <siedlerkiller@gmail.com>

protected/package private -> public

a96d10d

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Fix formatting

5ef3898

Make ArchitectureTest "real"

ed7218f

Fix typo in "cancelled"

4534ef9

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Fix JavaDoc

085bf66

Move execute(JavaFX Task) down to UiTaskExecutor

8b098cf

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Fixed an exception when searching for unlinked files.

ba790b2

Co-authored-by: Christoph <siedlerkiller@gmail.com>

koppor added dev: code-quality Issues related to code or architecture decisions project: jabcon labels Sep 8, 2024

koppor added 2 commits September 8, 2024 19:07

Sync main and branch

aa13053

Merge commit 'aa130' into fix-arch2

4de1c33

# Conflicts: # src/main/java/org/jabref/gui/LibraryTab.java

koppor force-pushed the fix-arch2 branch from 2844481 to 4de1c33 Compare September 8, 2024 17:15

Siedlerchr reviewed Sep 8, 2024

View reviewed changes

Comment thread CHANGELOG.md Outdated

koppor and others added 3 commits September 8, 2024 19:18

Fix CHANGELOG

0f7c5b5

Move TaskExecutor from gui to logic

8651afb

Co-authored-by: Christoph <siedlerkiller@gmail.com>

Fix more checkstyle

7e2b0e0

This comment was marked as outdated.

Sign in to view

Introduce NotifcationService

2bc0c63

Also: - Move openAiChat from AiService (logic) to GroupTree (gui)

This comment was marked as outdated.

Sign in to view

koppor mentioned this pull request Sep 8, 2024

Fixed an exception when searching for unlinked files. #11731

Merged

6 tasks

Relax migrations

505b22d

github-actions Bot reviewed Sep 12, 2024

View reviewed changes

calixtus and others added 10 commits September 14, 2024 00:03

Move PreferencesFilter to gui

8a1859b

Move LuceneIndexer to logic

15d4570

Remove preferences package from tests

9767ba7

Merge remote-tracking branch 'upstream/main' into fix-arch2

d6693a9

# Conflicts: # src/main/java/org/jabref/gui/ai/components/privacynotice/PrivacyNoticeComponent.java

Fix imports

3a0575a

Merge remote-tracking branch 'origin/main' into fix-arch2

aa13c18

# Conflicts: # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

Fix checkstyle

8c0f55f

Fix compile error

ce8fec0

Fix logger

bca08f9

Add workaround

aa05537

koppor added 8 commits September 14, 2024 23:23

Merge remote-tracking branch 'origin/main' into fix-arch2

48853d5

Discard changes to src/test/resources/org/jabref/logic/exporter/ModsE…

fa6bbea

…xportFormatTestOnlyRequiredFields.xml

Discard changes to src/test/resources/org/jabref/logic/exporter/ModsE…

5cd83f7

…xportFormatTestAllFields.xml

Reset *.xml to main

c8e1638

Creaate LastFilesOpenedPreferences

92d3631

Re-activate code for Server

5b4e059

NativeDesktop use is not restricted

bd4920a

Fix architecture test

9cf417e

koppor marked this pull request as ready for review September 15, 2024 00:37

calixtus approved these changes Sep 15, 2024

View reviewed changes

Siedlerchr added this pull request to the merge queue Sep 15, 2024

Merged via the queue into main with commit 7c958e7 Sep 15, 2024

Siedlerchr deleted the fix-arch2 branch September 15, 2024 09:08

koppor mentioned this pull request Oct 11, 2024

Prepares multi module build #11921

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix architecture gui/logic#11729

Fix architecture gui/logic#11729
Siedlerchr merged 126 commits intomainfrom
fix-arch2

koppor commented Sep 8, 2024 •

edited

Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot left a comment

Uh oh!

Siedlerchr commented Sep 14, 2024

Uh oh!

github-actions Bot commented Sep 15, 2024 •

edited

Loading

Uh oh!

Siedlerchr commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

koppor commented Sep 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mandatory checks

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Siedlerchr commented Sep 14, 2024

Uh oh!

github-actions Bot commented Sep 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Siedlerchr commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

koppor commented Sep 8, 2024 •

edited

Loading

github-actions Bot commented Sep 15, 2024 •

edited

Loading