Add format BibTeX source in JabRef style in import gui (continuing)#13591
Add format BibTeX source in JabRef style in import gui (continuing)#13591NewCodes7 wants to merge 2 commits intoJabRef:mainfrom
Conversation
|
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
![trag-bot[bot]](https://avatars.githubusercontent.com/in/856808?s=60&v=4){kind=small}
| if (!viewModel.hasDuplicate(entry)) { | ||
| entriesListView.getCheckModel().check(entry); | ||
| displayBibTeX(entry, viewModel.getSourceString(entry)); | ||
| displayBibTeX(entry, viewModel.getSourceString(entry, true)); |
There was a problem hiding this comment.
The boolean parameter true is a magic value that makes the code less maintainable and readable. Consider creating an enum or named constant to clarify the parameter's purpose.
|
JUnit tests of You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
| try { | ||
| new BibEntryWriter(fieldWriter, entryTypesManager).write(entry, bibWriter, selectedDb.getValue().getMode()); | ||
| serializedStrings = new BibEntryWriter(fieldWriter, entryTypesManager).serializeAll(entries, selectedDb.getValue().getMode()); | ||
| } catch (IOException ioException) { |
There was a problem hiding this comment.
Empty string is returned on IOException without logging or proper error handling. This silently fails and may hide important issues from users and developers.
Nice! We always encourage contributors to share code changes early. I'll go ahead and convert this PR to a draft so it's clear it's still in progress. Feel free to mark it as "Ready for Review" once it's good to go |
May I ask about a timeline? We are trying to reduce the number of opened pull request - and there was no activity since one month here. |
|
The solution at #13761 is much more simple and works. I think, I did not overlook something. Sometimes, its just small changes with a huge impact to the user. |
4 participants
Closes #13015
I'm still working on it at the moment. I just posted PR quickly first.
Closes _____
Steps to test
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)