Skip to content

Restore local-only Git behavior for SLR to fix repository initialization error#13775

Merged
Siedlerchr merged 3 commits intoJabRef:mainfrom
wanling0000:fix/13773-slr-githandler
Aug 27, 2025
Merged

Restore local-only Git behavior for SLR to fix repository initialization error#13775
Siedlerchr merged 3 commits intoJabRef:mainfrom
wanling0000:fix/13773-slr-githandler

Conversation

@wanling0000
Copy link
Copy Markdown
Collaborator

@wanling0000 wanling0000 commented Aug 27, 2025

Closes #13773
This PR fixes a regression where the GitHandler.pullOnCurrentBranch() method was modified to support remote repositories. However, the same method is also used in the SLR module for local-only study repositories, which have no remote set up by default.

To fix this, we reverted to the original behavior where the method attempts to pull from a remote (if configured), but silently ignores errors when no remote is present. This preserves compatibility with local-only workflows (like the SLR module).

Mandatory checks

@wanling0000 wanling0000 changed the title Fix SLR study initialization: restore fallback local pull if no remot… Restore local-only Git behavior for SLR to fix repository initialization error Aug 27, 2025
Comment thread CHANGELOG.md Outdated

### Fixed

- We fixed an error when starting a new Systematic Literature Review due to a missing remote Git repository. [#13773](https://github.com/JabRef/jabref/issues/13773)
Copy link
Copy Markdown
Member

@subhramit subhramit Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we started working on the Git project in the current unreleased version? In that case - the issue occurred in the unreleased version, so we can remove this entry.

@trag-bot
Copy link
Copy Markdown

trag-bot Bot commented Aug 27, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr enabled auto-merge August 27, 2025 21:33
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 27, 2025
Merged via the queue into JabRef:main with commit ac42aa7 Aug 27, 2025
1 check passed
Siedlerchr added a commit that referenced this pull request Aug 28, 2025
…n-c23b1a88-5c29-46a2-a007-701edd344b9b' into jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b

* upstream/jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b:
  Streamline code for getTabTitle() (#13781)
  Add missing variables
  Reformat BibTex in Show BibTex Source (#13761)
  Auto publish before JBang tests (#13779)
  Hotfix: calling of publish.yml
  Support BibLaTeX datamodel validations (#13693)
  Auto add and remove of "status: changes-required" label (#13778)
  New Crowdin updates (#13777)
  Restore local-only Git behavior for SLR to fix repository initialization error (#13775)
  Use vanilla hashset (#13771)
  Fix Springer Fetcher names (#13770)
  Fix condition
  Publish SNAPSHOT on jablib change (#13774)
  Adapt as per new set of checks (#13772)
  Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750)
  Fix path (#13769)
  Mode aware consistency check (#13584)
  Refine JBang check (#13765)
  Add Language Server to the UI and add the integrity/consistency check (#13697)
  Fix/remove comment code (#13763)
Siedlerchr added a commit that referenced this pull request Sep 8, 2025
* upstream/main:
  Add missing variables
  Reformat BibTex in Show BibTex Source (#13761)
  Auto publish before JBang tests (#13779)
  Hotfix: calling of publish.yml
  Support BibLaTeX datamodel validations (#13693)
  Auto add and remove of "status: changes-required" label (#13778)
  New Crowdin updates (#13777)
  Restore local-only Git behavior for SLR to fix repository initialization error (#13775)
  Use vanilla hashset (#13771)
  Fix Springer Fetcher names (#13770)
  Fix condition
  Publish SNAPSHOT on jablib change (#13774)
  Adapt as per new set of checks (#13772)
  Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Systematic Literature Research gives 'study repository not found' error

3 participants