Automatic field editor: Add Clear content tab + viewmodel by Akanksha928 · Pull Request #13824 · JabRef/jabref

Akanksha928 · 2025-09-06T17:34:47Z

Closes #13780

This PR introduces a dedicated "Clear content" tab in the Automatic Field Editor:

Added a new "Clear content" tab with a dropdown to select the field to clear
Added a "Show only set fields" checkbox to filter the dropdown to fields actually filled in selected entries
Removed the "Clear field content" button from the "Edit content" tab (moved functionality to the new tab)
Clearing supports Undo/Redo via NamedCompound + UndoableFieldChange
Added i18n keys for all new UI text

Steps to test

Open or create a library with a few entries (fill in some fields like author, journal).
Select one or more entries.
Open Edit → Automatic field editor.
Switch to the new Clear content tab.
Toggle the "Show only set fields" checkbox: the dropdown should shrink to only the fields currently filled.
Select a field (e.g., author) and click Clear field content: the field value should be removed from all selected entries.
Press Ctrl+Z: the cleared field(s) should be restored.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Siedlerchr · 2025-09-08T19:15:03Z

+            Field chosen = fieldCombo.getValue();   // keep ComboBox<Field>
+            if (chosen != null) {
+                viewModel.clearField(chosen);       // VM builds/publishes the undo compound
+                System.out.println("Cleared field: " + chosen.getName());


No System.out and remove the comments

Siedlerchr · 2025-09-08T19:15:29Z

+
+        List<BibEntry> selected = stateManager.getSelectedEntries();
+        for (BibEntry entry : selected) {
+            // clearField returns Optional<FieldChange>


remove comments

Siedlerchr · 2025-09-08T19:15:40Z

+        List<BibEntry> selected = stateManager.getSelectedEntries();
+        Set<Field> setFields = new LinkedHashSet<>();
+
+        for (BibEntry entry : selected) {


can be refactored into a stream

Siedlerchr · 2025-09-08T19:16:14Z

+    private final ClearContentViewModel viewModel;
+
+    public ClearContentTabView(StateManager stateManager) {
+        super();


Is there a reasony why you did not creae an fxml? I guess you used AI..

Yes, I initially used AI to generate the layout in Java so I could focus on getting the logic working first but forgot to move it into a proper FXML file. I've made the changes now.

calixtus

.

calixtus · 2025-09-08T20:16:13Z

Sorry, misunderstood PR. Nevermind.

…cted files

calixtus · 2025-10-06T21:58:57Z

+import org.jabref.model.entry.field.FieldFactory;
+
+public class ClearContentViewModel {
+    public static final int TAB_INDEX = 2;


TAB_INDEX constant is horrible, but is actually consistent with the current design of the dialog. Neccessary for the fancy infotext about affected files after applying the change. Should be refactored in the future, but for now, it can just stay.

jabref-machine · 2025-10-07T11:18:05Z

You did not assign yourself to the issue. Thus, it looks like you skipped reading our CONTRIBUTING.md, which explains exactly how to participate. No worries, it happens to the best of us.

Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀

* upstream/main: (85 commits) Fix typo in PR template (add missing 'to') (JabRef#14050) New Crowdin updates (JabRef#14049) Switch to new macos intel runner and update arm runner as well (JabRef#14048) Automatic field editor: Add Clear content tab + viewmodel (JabRef#13824) Update dependency org.eclipse.jgit:org.eclipse.jgit.pgm to v7.4.0.202509020913-r (JabRef#14046) Rephrase JabRef-Machine's "Determine issue number" (JabRef#14044) Chore(deps): Bump com.vanniktech.maven.publish from 0.32.0 to 0.34.0 in /jablib (JabRef#14039) Chore(deps): Bump org.mockito:mockito-core in /jablib (JabRef#14038) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#14037) Chore(deps): Bump com.dlsc.pdfviewfx:pdfviewfx in /versions (JabRef#14040) Chore(deps): Bump lucene from 10.3.0 to 10.3.1 in /versions (JabRef#14042) Fix eadr missing (JabRef#14043) Enable update in versions of jablib (JabRef#14036) Update Gradle Wrapper from 9.3.0-jabref-1 to 9.1.0 (JabRef#14033) Implemented OpenAlex (JabRef#14020) Chore(deps): Bump peter-evans/create-or-update-comment from 4 to 5 (JabRef#14023) Chore(deps): Bump org.cyclonedx.bom from 3.0.0-alpha-1 to 3.0.0 (JabRef#14026) Chore(deps): Bump org.junit.jupiter:junit-jupiter in /versions (JabRef#14030) Chore(deps): Bump com.github.andygoossens:gradle-modernizer-plugin (JabRef#14027) Chore(deps): Bump org.mockito:mockito-core in /versions (JabRef#14028) ...

* Automatic field editor: Add Clear content tab + viewmodel * Removing comments * PR comment changes * Bot suggested changes * Bot suggested changes * reformat * fix fxml * Added tests, reformats and visual modifications. Fixed number of affected files * Fixed tab number * CHANGELOG.md --------- Co-authored-by: Siedlerchr <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <calixtus@users.noreply.github.com>

Akanksha928 added 2 commits September 6, 2025 10:30

Automatic field editor: Add Clear content tab + viewmodel

137fddf

Removing comments

bb07ec4

Siedlerchr requested changes Sep 8, 2025

View reviewed changes

Siedlerchr added the status: changes-required Pull requests that are not yet complete label Sep 8, 2025

calixtus requested changes Sep 8, 2025

View reviewed changes

Akanksha928 added 3 commits September 10, 2025 21:28

PR comment changes

6c2e29a

Bot suggested changes

e8185b1

Bot suggested changes

9afbe20

trag-bot Bot reviewed Sep 11, 2025

View reviewed changes

Comment thread ...rc/main/java/org/jabref/gui/edit/automaticfiededitor/clearcontent/ClearContentViewModel.java

merge

c0edaaf

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Oct 6, 2025

Siedlerchr requested a review from calixtus October 6, 2025 20:05

Siedlerchr and others added 4 commits October 6, 2025 22:09

reformat

3320a9d

fix fxml

acd1ddb

Added tests, reformats and visual modifications. Fixed number of affe…

049fa0d

…cted files

Fixed tab number

c1a059b

calixtus reviewed Oct 6, 2025

View reviewed changes

calixtus previously approved these changes Oct 6, 2025

View reviewed changes

calixtus enabled auto-merge October 6, 2025 21:59

calixtus requested a review from Siedlerchr October 6, 2025 22:00

CHANGELOG.md

2a6a62e

calixtus dismissed their stale review via 2a6a62e October 6, 2025 22:04

calixtus approved these changes Oct 6, 2025

View reviewed changes

JabRef deleted a comment from jabref-machine Oct 7, 2025

Siedlerchr approved these changes Oct 7, 2025

View reviewed changes

calixtus added this pull request to the merge queue Oct 7, 2025

Merged via the queue into JabRef:main with commit 0a63038 Oct 7, 2025
82 of 85 checks passed

github-actions Bot mentioned this pull request Oct 7, 2025

Automatic field editor: Checkbox: Show only set fields #13780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Automatic field editor: Add Clear content tab + viewmodel#13824

Automatic field editor: Add Clear content tab + viewmodel#13824
calixtus merged 11 commits intoJabRef:mainfrom
Akanksha928:feat/automatic-field-editor-clear-tab

Akanksha928 commented Sep 6, 2025

Uh oh!

Siedlerchr Sep 8, 2025

Uh oh!

Siedlerchr Sep 8, 2025

Uh oh!

Siedlerchr Sep 8, 2025

Uh oh!

Siedlerchr Sep 8, 2025

Uh oh!

Akanksha928 Sep 11, 2025

Uh oh!

calixtus left a comment

Uh oh!

calixtus commented Sep 8, 2025

Uh oh!

Uh oh!

calixtus Oct 6, 2025

Uh oh!

jabref-machine commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Akanksha928 commented Sep 6, 2025

Steps to test

Mandatory checks

Uh oh!

Siedlerchr Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Siedlerchr Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Akanksha928 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

calixtus left a comment

Choose a reason for hiding this comment

Uh oh!

calixtus commented Sep 8, 2025

Uh oh!

Uh oh!

calixtus Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

jabref-machine commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants