Skip to content

Fix typos#14552

Merged
koppor merged 1 commit intomainfrom
code-style-improvements
Dec 8, 2025
Merged

Fix typos#14552
koppor merged 1 commit intomainfrom
code-style-improvements

Conversation

@koppor
Copy link
Copy Markdown
Member

@koppor koppor commented Dec 8, 2025

Follow-up to #14370

Mandatory checks

@koppor koppor requested a review from subhramit December 8, 2025 15:46
Siedlerchr
Siedlerchr reviewed Dec 8, 2025
View reviewed changes
Comment thread jablib/src/main/java/org/jabref/logic/util/ExternalLinkCreator.java
for (Author authorObject : authors) {
uriBuilder.addParameter("author[" + idx + "]", authorObject.getNameForAlphabetization());
++idx;
idx++;
Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure this is wanted?

Copy link
Copy Markdown
Member Author

@koppor koppor Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same! idx is increased by one. - Its a difference If I do "System.out.println(i++)" versus "System.out.println(++i)"

@koppor koppor added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 37e5caf Dec 8, 2025
62 checks passed
@koppor koppor deleted the code-style-improvements branch December 8, 2025 20:12
shubhamk0205 pushed a commit to shubhamk0205/jabref that referenced this pull request Dec 8, 2025
@koppor @shubhamk0205
Fix typos (JabRef#14552)
bc36bdb
github-merge-queue Bot pushed a commit that referenced this pull request Dec 11, 2025
@shubhamk0205 @Siedlerchr
@koppor @lalit2506verma
Add 15 non-standard BibLaTeX entry types with .withType() method (#14534
aafb809 
)

* Add 15 non-standard BibLaTeX entry types with .withType() method

* updated ChangeLog.md

* fixed formatting issue

* fixed Formatting

* fixed Checkstyle's DeclarationOrder

* fix checkstyle errors

* fixed Key Collision error

* New Crowdin updates (#14535)

* New translations jabref_en.properties (French)

* New translations jabref_en.properties (Spanish)

* New translations jabref_en.properties (Danish)

* New translations jabref_en.properties (German)

* New translations jabref_en.properties (Greek)

* New translations jabref_en.properties (Italian)

* New translations jabref_en.properties (Japanese)

* New translations jabref_en.properties (Korean)

* New translations jabref_en.properties (Dutch)

* New translations jabref_en.properties (Norwegian)

* New translations jabref_en.properties (Polish)

* New translations jabref_en.properties (Portuguese)

* New translations jabref_en.properties (Russian)

* New translations jabref_en.properties (Swedish)

* New translations jabref_en.properties (Turkish)

* New translations jabref_en.properties (Chinese Simplified)

* New translations jabref_en.properties (Vietnamese)

* New translations jabref_en.properties (Portuguese, Brazilian)

* New translations jabref_en.properties (Indonesian)

* New translations jabref_en.properties (Tagalog)

* Revise JavaDoc links in README.md (#14533)

* applied given changes

* fixed formatting

* fixed formatting

* Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* fixed alphabatical ordering

* Fix link

* Proxy Preference reset (#14554)

* Fix typos (#14552)

* Add LlmPlainCitationParserTest (#14553)

* Junie try 1

* Refine test

* Fix casing

* updated ChangeLog.md

* moved the non-standard types to their own own enum class and updated the connected files

* eevert "Proxy Preference reset (#14554)"

This reverts commit 430b6b9.

Clean PR

* Fix CHANGELOG.md

---------

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>
shubhamk0205 pushed a commit to shubhamk0205/jabref that referenced this pull request Dec 11, 2025
@koppor @shubhamk0205
Fix typos (JabRef#14552)
6825062
shubhamk0205 added a commit to shubhamk0205/jabref that referenced this pull request Dec 11, 2025
@shubhamk0205 @Siedlerchr
@koppor @lalit2506verma
Add 15 non-standard BibLaTeX entry types with .withType() method (Jab…
d7451cf 
…Ref#14534)

* Add 15 non-standard BibLaTeX entry types with .withType() method

* updated ChangeLog.md

* fixed formatting issue

* fixed Formatting

* fixed Checkstyle's DeclarationOrder

* fix checkstyle errors

* fixed Key Collision error

* New Crowdin updates (JabRef#14535)

* New translations jabref_en.properties (French)

* New translations jabref_en.properties (Spanish)

* New translations jabref_en.properties (Danish)

* New translations jabref_en.properties (German)

* New translations jabref_en.properties (Greek)

* New translations jabref_en.properties (Italian)

* New translations jabref_en.properties (Japanese)

* New translations jabref_en.properties (Korean)

* New translations jabref_en.properties (Dutch)

* New translations jabref_en.properties (Norwegian)

* New translations jabref_en.properties (Polish)

* New translations jabref_en.properties (Portuguese)

* New translations jabref_en.properties (Russian)

* New translations jabref_en.properties (Swedish)

* New translations jabref_en.properties (Turkish)

* New translations jabref_en.properties (Chinese Simplified)

* New translations jabref_en.properties (Vietnamese)

* New translations jabref_en.properties (Portuguese, Brazilian)

* New translations jabref_en.properties (Indonesian)

* New translations jabref_en.properties (Tagalog)

* Revise JavaDoc links in README.md (JabRef#14533)

* applied given changes

* fixed formatting

* fixed formatting

* Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* fixed alphabatical ordering

* Fix link

* Proxy Preference reset (JabRef#14554)

* Fix typos (JabRef#14552)

* Add LlmPlainCitationParserTest (JabRef#14553)

* Junie try 1

* Refine test

* Fix casing

* updated ChangeLog.md

* moved the non-standard types to their own own enum class and updated the connected files

* eevert "Proxy Preference reset (JabRef#14554)"

This reverts commit 430b6b9.

Clean PR

* Fix CHANGELOG.md

---------

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
@koppor @Siva-Sai22
Fix typos (JabRef#14552)
7ff5bed
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
@shubhamk0205 @Siedlerchr
@koppor @lalit2506verma @Siva-Sai22
Add 15 non-standard BibLaTeX entry types with .withType() method (Jab…
7cbe70c 
…Ref#14534)

* Add 15 non-standard BibLaTeX entry types with .withType() method

* updated ChangeLog.md

* fixed formatting issue

* fixed Formatting

* fixed Checkstyle's DeclarationOrder

* fix checkstyle errors

* fixed Key Collision error

* New Crowdin updates (JabRef#14535)

* New translations jabref_en.properties (French)

* New translations jabref_en.properties (Spanish)

* New translations jabref_en.properties (Danish)

* New translations jabref_en.properties (German)

* New translations jabref_en.properties (Greek)

* New translations jabref_en.properties (Italian)

* New translations jabref_en.properties (Japanese)

* New translations jabref_en.properties (Korean)

* New translations jabref_en.properties (Dutch)

* New translations jabref_en.properties (Norwegian)

* New translations jabref_en.properties (Polish)

* New translations jabref_en.properties (Portuguese)

* New translations jabref_en.properties (Russian)

* New translations jabref_en.properties (Swedish)

* New translations jabref_en.properties (Turkish)

* New translations jabref_en.properties (Chinese Simplified)

* New translations jabref_en.properties (Vietnamese)

* New translations jabref_en.properties (Portuguese, Brazilian)

* New translations jabref_en.properties (Indonesian)

* New translations jabref_en.properties (Tagalog)

* Revise JavaDoc links in README.md (JabRef#14533)

* applied given changes

* fixed formatting

* fixed formatting

* Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* fixed alphabatical ordering

* Fix link

* Proxy Preference reset (JabRef#14554)

* Fix typos (JabRef#14552)

* Add LlmPlainCitationParserTest (JabRef#14553)

* Junie try 1

* Refine test

* Fix casing

* updated ChangeLog.md

* moved the non-standard types to their own own enum class and updated the connected files

* eevert "Proxy Preference reset (JabRef#14554)"

This reverts commit 430b6b9.

Clean PR

* Fix CHANGELOG.md

---------

Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@subhramit subhramit Awaiting requested review from subhramit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koppor @Siedlerchr