Revert "Reduce complexity in dependencies setup"#15191
Conversation
This reverts commit 10196d5.
Siedlerchr
deleted the
revert-15169-reduce-complexity-in-dependencies-setup
branch
Review Summary by QodoRevert "Reduce complexity in dependencies setup" and restore module configuration
WalkthroughsDescription• Revert complexity reduction in module dependencies setup • Restore explicit module requirements removed in previous commit • Fix module-info declarations across all JabRef modules • Migrate from testModuleInfo DSL to javaModuleTesting.whitebox API • Consolidate build.gradle.kts dependency declarations • Remove unused dependency analysis plugin and custom metadata rules Diagramflowchart LR
A["Previous Simplified<br/>Module Setup"] -->|Revert| B["Restored Explicit<br/>Module Requirements"]
B --> C["Updated module-info.java<br/>Files"]
B --> D["Migrated testModuleInfo<br/>to javaModuleTesting"]
B --> E["Consolidated build.gradle.kts<br/>Dependencies"]
C --> F["Fixed GUI Startup<br/>Issues"]
File Changes1. jabgui/src/main/java/module-info.java
|
Code Review by Qodo
1. Commented-out jacoco block
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
| /* | ||
| jacoco { | ||
| toolVersion = "0.8.13" | ||
| } | ||
| */ |
There was a problem hiding this comment.
1. Commented-out jacoco block 📘 Rule violation ✓ Correctness
A commented-out jacoco configuration block was added, leaving dead code in the build script. This reduces maintainability and violates the requirement to remove commented-out code.
Agent Prompt
## Issue description
A commented-out `jacoco` configuration block was added to the build script, which is dead code.
## Issue Context
The compliance checklist requires removing commented-out code instead of keeping disabled blocks in source.
## Fix Focus Areas
- jablib/build.gradle.kts[240-244]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| // PATCH REASON: | ||
| exports("com.sun.javafx.scene.control") |
There was a problem hiding this comment.
2. // patch reason: has no reason 📘 Rule violation ✓ Correctness
An incomplete comment (// PATCH REASON:) was added without any explanation of intent/why. This is a trivial comment that harms readability.
Agent Prompt
## Issue description
An incomplete/trivial comment was added (`// PATCH REASON:`) without stating the actual reason.
## Issue Context
Comments should explain intent/why; placeholders reduce code clarity and violate the project's comment guidelines.
## Fix Focus Areas
- build-logic/src/main/kotlin/org.jabref.gradle.base.dependency-rules.gradle.kts[527-528]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| requires javafx.base; | ||
|
|
||
| // For CAYW feature | ||
| requires transitive javafx.graphics; | ||
| requires transitive javafx.controls; | ||
| requires afterburner.fx; | ||
| requires java.desktop; | ||
|
|
||
| // For ServiceLocatorUtilities.createAndPopulateServiceLocator() | ||
| requires /*runtime*/ org.glassfish.hk2.locator; | ||
| requires org.glassfish.hk2.locator; | ||
| uses org.jvnet.hk2.external.generator.ServiceLocatorGeneratorImpl; | ||
|
|
||
| requires transitive org.jabref.jablib; | ||
| requires org.jabref.jablib; | ||
|
|
There was a problem hiding this comment.
3. Missing java.desktop require 🐞 Bug ✓ Correctness
jabsrv code imports java.awt.* (java.desktop) but module-info no longer requires java.desktop, which should break JPMS compilation/module resolution. This is a hard failure (not just a logging/behavior change).
Agent Prompt
### Issue description
`org.jabref.jabsrv` uses AWT (`java.awt.*`) but its `module-info.java` does not read the `java.desktop` module. Under JPMS this causes compilation/module resolution errors (e.g., `package java.awt is not visible`).
### Issue Context
The CAYW endpoint (`CAYWResource`) uses `java.awt.Toolkit` and `java.awt.datatransfer.*`.
### Fix Focus Areas
- jabsrv/src/main/java/module-info.java[19-35]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
…les-wizard-12709 * upstream/main: (106 commits) Merge common gating parts into composite action (JabRef#15197) Support protected institutional authors in PersonNamesChecker (JabRef#15175) adapt wix (JabRef#14969) Improve CI (JabRef#15189) Revert "Reduce complexity in dependencies setup (JabRef#15169)" (JabRef#15191) Fix compilation Fix heylogs test Fix icon on Linux (JabRef#15188) chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3.5.5 (JabRef#15178) New Crowdin updates (JabRef#15173) Reduce complexity in dependencies setup (JabRef#15169) Start new development cycle snapcraft snapcraft use snapctl update metadata fiels try with mesa candidate fix snapcraft and skmanrc to use correct version Release v6.0-alpha.5 chore(sbom): update CycloneDX SBOM files (JabRef#15172) ...
1 participant
Reverts #15169
Breaks starting of jabref gui