Conversation
Add the two new checkboxes to configuration UI
Add it to preferences TODO: Add migration
Remove unused settings
Remove overwriteTimestamp (always enabled), use ISO_LOCAL_DATE_TIME formatter, use CREATIONDATE field
Siedlerchr
reviewed
Jan 13, 2021
calixtus
previously requested changes
Jan 13, 2021
Member
calixtus
left a comment
calixtus
left a comment
There was a problem hiding this comment.
Three small questions/remarks.
Change locale
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
koppor
previously approved these changes
Jan 14, 2021
Siedlerchr
previously approved these changes
Jan 14, 2021
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
One checkstyle issue left, otherwise lgtm
koppor
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the creationdate and modificationdate fields. Refs koppor#130.
It provides migration to these new fields from the timestamp field.
If the old "Update timestamp on modification" option is active, the timestamp will be migrated to the modification field. Otherwise, it will be migrated to the creationdate field.
This migration also ports many of the most used date formats to the ISO8601 standard.
An example of this:
2020-03-17T12:28:32 (yyyy-mm-ddThh:mm:ss).The time portion of these migrated entries is set to 00:00:00.
The automatic creation/updating of both fields can be configured in the preferences dialog at the same place the previous function could be configured.
For the time portion, the locale time is used and truncated to the precision of seconds.