Add semantic scholar#8575
Merged
Siedlerchr merged 17 commits intoJabRef:mainfrom Mar 22, 2022
Merged
Conversation
Member
|
Does this fix #6627? |
Contributor
Author
Siedlerchr
reviewed
Mar 15, 2022
Siedlerchr
reviewed
Mar 15, 2022
Siedlerchr
reviewed
Mar 15, 2022
Siedlerchr
reviewed
Mar 15, 2022
Siedlerchr
reviewed
Mar 15, 2022
Siedlerchr
requested changes
Mar 15, 2022
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
Looks already very good! 👍 Will test this asap.
Just some minor suggestions
Siedlerchr
added
status: ready-for-review
Member
|
Oh and don't forget changelog |
Siedlerchr
reviewed
Mar 16, 2022
Siedlerchr
requested changes
Mar 16, 2022
added 8 commits
March 16, 2022 20:15
etienne428
force-pushed
the
add-semantic-scholar
branch
from
503134e to
9c853e4
Compare
Siedlerchr
removed
the
status: changes-required
Siedlerchr
approved these changes
Mar 16, 2022
Member
Siedlerchr
left a comment
Siedlerchr
left a comment
There was a problem hiding this comment.
Thanks again for this cool new feature :)
calixtus
approved these changes
Mar 21, 2022
Member
|
Made a little change in the changelog to fit in the common wording. Thanks for your effort! |
Member
|
Can you also disable the Semantic scholar tests on CI? They throw an 429 error too many requests |
Siedlerchr
added a commit
that referenced
this pull request
Mar 27, 2022
* upstream/main: (104 commits) update test getPart (#8610) Add ControlHelper truncateString tests comments (#8612) Allow using custom SSL certificates (#8583) Fix protectedTerms not stored due to weaklistener (#8609) Fix changelog and version parsing (#8578) Creating more unit tests for NumericFieldComparatorTest (#8604) Fix merge entries dialog exceeding screen size (#8599) StringUtilTest new test for method GetPart (#8594) Use unkown entry type Add semantic scholar (#8575) Add research gate (#8580) fix import of unlinked files (#8444) (#8582) Missed l10n for fetcher fix (#8597) Fix some fetcher test (#8595) Bump slf4j-api from 2.0.0-alpha6 to 2.0.0-alpha7 in /buildSrc (#8589) Bump ikonli-materialdesign2-pack from 12.3.0 to 12.3.1 (#8591) Bump gittools/actions from 0.9.11 to 0.9.13 (#8587) Bump mockito-core from 4.3.1 to 4.4.0 (#8588) Bump flowless from 0.6.8 to 0.6.9 (#8590) Bump ikonli-javafx from 12.3.0 to 12.3.1 (#8592) ... # Conflicts: # src/main/java/org/jabref/gui/EntryTypeViewModel.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)