Skip to content

Add restart warning on SSL configuration change#8871

Merged
Siedlerchr merged 5 commits intomainfrom
fix-ssl-at-fetcher
May 31, 2022
Merged

Add restart warning on SSL configuration change#8871
Siedlerchr merged 5 commits intomainfrom
fix-ssl-at-fetcher

Conversation

@koppor
Copy link
Copy Markdown
Member

@koppor koppor commented May 30, 2022

Follow up to #8583

I did following:

  1. fetch DOI
  2. see SSL error
  3. add custom SSL certificate
  4. fetch DOI
  5. see SSL error
  6. restart JabRef
  7. fetch DOI
  8. see DOI

To prevent WTFs at users, I added a restart warning:

image

I digged in the code for URLDownload, but could not find the place for ssl certficate handling. I would assume, Java does some caching...

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr merged commit 8b05a5c into main May 31, 2022
@Siedlerchr Siedlerchr deleted the fix-ssl-at-fetcher branch May 31, 2022 18:29
Siedlerchr added a commit that referenced this pull request Jun 1, 2022
* upstream/main:
  Add an importer for Citavi backup files (#8848)
  Reviewdoc: Comment on PRs (#8878)
  Squashed 'buildres/csl/csl-styles/' changes from 649aac4..e740261
  Use JDK 15 text blocks to improve injected languages readability (#8874)
  Fix fetcher tests (#8877)
  Fix #8390 by allowing multiple group deletion for Remove groups > Kee… (#8875)
  Add restart warning on SSL configuration change (#8871)
  Update to lucene 9.2 (#8868)
  Fix for removing several groups deletes only one of them (#8801)
  Disable Write XMP Button in General tab of Entry-Editor when action is in progress (#8728)
  Bump jsoup from 1.14.3 to 1.15.1 (#8864)
  Bump unirest-java from 3.13.8 to 3.13.10 (#8869)
  Bump unoloader from 7.3.2 to 7.3.3 (#8863)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (#8860)
  Bump classgraph from 4.8.146 to 4.8.147 (#8861)
  Bump mockito-core from 4.5.1 to 4.6.0 (#8862)
  Lucence dir checkers should only delete lucence dirs (#8854)
  Update README.md (#8858)
  Update adr.md
  Update adr.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants