Skip to content

Feature: Add a "Search Authors in GoogleScholar" feature#8886

Closed
Christina0114 wants to merge 5 commits intoJabRef:mainfrom
Christina0114:feat/arthur
Closed

Feature: Add a "Search Authors in GoogleScholar" feature#8886
Christina0114 wants to merge 5 commits intoJabRef:mainfrom
Christina0114:feat/arthur

Conversation

@Christina0114
Copy link
Copy Markdown
Contributor

@Christina0114 Christina0114 commented Jun 2, 2022

I add a "Search Authors in GoogleScholar" in "RightClickMenu".
Screen Shot 2022-06-02 at 10 46 00
If user clicks a author's name, it will pop up a GoogleScholar Page:
image

I add “LookArthurMenu” in RightClickMenu class and also a LookupAuthorAction class. Besides, I add another CustomizedAction class to dynamically create new actions while the original StandardActions is an enum that can’t be added/ changed dynamically.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@ThiloteE
Copy link
Copy Markdown
Member

ThiloteE commented Jun 2, 2022

Interesting Idea. Since there was no discussion and you have not tried to fix an existing issue, the discussion will have to be in this pull-request I guess. Hence, here my feedback about your UI design choice:

I am not sure if this option is important enough to show in the right-click menu. It is very specific to Google. What if we wanted to add a similar feature that links to other portals and search engines? - search shortscience actually falls into this category as well. One could also think about searching for other metadata, not just author. E.g. Opening the journal-page comes to mind. The right-click menu would become longer and longer.

  1. Option: Integrate this into the entry editor next to the author field. See here:
    grafik
    - a little hidden
    + does not take space from right-click menu
    + close to author field
    - what about other fields like e.g. editor?
    - is this really about "editing" an entry? Is entry-editor the right choice?

  2. Option: Allow to left-click on certain columns in the maintable. See here:
    grafik
    + Easy, fast access for user
    - Selecting a specific entry in the maintable becomes more difficult, because it might trigger the search for author instead of selecting the entry.
    - More difficult to implement, because has to be implement for multiple fields. Which fields exactly? Only author?
    + Something similar has been implemented for e.g. linked files. They allow users to choose a specific file from the maintable. See Fix single identifier cannot be opened on click #8838 and Allows to open identifiers from a popup in the maintable (e.g. URL, DOI, ...). Fixes issues #8758 and #8802 #8817

  3. Option: Move Search Authors in GoogleScholar and Search Shortscience to Lookup
    grafik
    + resonates with the idea of "lookup"
    - the other items in Lookup are of general nature and at the very core of entry metadata. Search Authors in GoogleScholar and Search Shortscience might not necessarily need such a prominent place in the UI.

  4. Option:

    • 4A: Implement it like you did here in your pull-request.
    • 4B: Implement it like you did here in your pull-request, but go beyond that: Consolidate search authors in GoogleScholar and search Shortscience into a single search... (or something similar).

    For both:
    + you already did some work, so it does not go to waste
    + easy, fast and intuitive access to author search.
    - See critique from above.

    Currently I personally favour Option 4B, but I hope I have shown that there are multiple possibilities for implementation.

@HoussemNasri
Copy link
Copy Markdown
Member

Refs #7075, JabRef#554

@koppor
Copy link
Copy Markdown
Member

koppor commented Jun 6, 2022

I really like the prominent button, since it helps in the "browsing" mode of JaRef.

Decision

  • Create sub menu "Search..." and put "Search Google Scholar" and "Search Short Science" into it.
  • "Search Google Scholar" implements following functionality: Google Scholar is searched for the title (simlar to ShortScience). This fixes Offer search in Google Scholar jabref-koppor#554.
  • Put the current implemented functionality to the sub menu "Search..." (keeping the label)
  • If possible, Additionally implement option 1 of Feature: Add a "Search Authors in GoogleScholar" feature #8886 (comment)
  • If possible, add a similar button to "Title". The button then opens a menu with two options: "Search Short Science" and "Search Google Scholar"
  • If possible, put Thilo's text + grahpics into an ADR markdown file.

@Siedlerchr
Copy link
Copy Markdown
Member

Siedlerchr commented Jul 15, 2022

Closing this PR due to inactivity 💤

@Siedlerchr Siedlerchr closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants