upgrade to node 13.x #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Travis shows this breaking Node versions 6 - 12, which is not ideal. Additionally I'd like to see Node v13 added to the build matrix if support added. Node 8 is the last officially supported Node version though so dropping 6 at this point is fine, but it works anyways that's ideal. |
Merged
Owner
|
Closing in favor of #14. Thanks for the excellent work! I've included your commit from this PR, and have added additional fixes to correct the build in older node versions as requested in my previous comment. I'll be authoring a new minor release soon that will include this an other fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.