Update NetlinkWrapper do accommodate changes in v8 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2019 08:44
…xt and the return type changed to Maybe<T>
added 5 commits
July 2, 2019 11:13
Owner
|
Thank you so much! I will manually check this evening. If it looks solid using nvm to switch between v8 <--> 10 I'll merge this and issue, and do a new release on npm. Looking over the changes here on GitHub I see no breaking changes, meaning a new major version release should not be necessary. Are there any breaking changes I should be aware of? |
Author
|
Thank you @JacobFischer for being so responsive, I have build it myself with different node version by switching between 6, 8 and 10 locally and haven't observed any issues. I also added 4 different node versions to Travis CI 9763658 and the test passed
|
Owner
|
Great work. Thanks again. |
Closed
|
@JacobFischer Will there be a new release on npm? |
Owner
|
Yes, literally working on that right now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix issue #8
v8 had breaking changes where it now favors the usage of
LocaloverHandleand most functions require the passing of either anIsolateorContext. In addition to that the return type of some functions has changed toMaybe<T>which requires to callToChecked()on the returned valued.I added a matrix build to Travis .travis.yml` in order to ensure compatibility with Node 6, 8, 10 and 12