add missing jsdoc imports and defs #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceres6
commented
Jan 7, 2025
lib/internal/modules/esm/loader.js
Outdated
| */ | ||
|
|
||
| /** | ||
| * @typedef {Object} Customizations |
Owner
There was a problem hiding this comment.
I think you want object (little o)
Owner
There was a problem hiding this comment.
I think this definition already exists in customization_hooks too
Collaborator
Author
There was a problem hiding this comment.
I fixed the first one, couldn't find a definition in customization_hooks
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
lib/internal/modules/esm/loader.js
Outdated
Comment on lines
119
to
127
| /** | ||
| * @typedef {object} Customizations | ||
| * @property {boolean} allowImportMetaResolve | ||
| * @property {(url: string, context: object) => Promise<ModuleLoadResult>} load | ||
| * @property {(originalSpecifier: string, parentURL: string, importAttributes: Record<string, string>) => Promise<ModuleResolveResult>} resolve | ||
| * @property {(originalSpecifier: string, parentURL: string, importAttributes: Record<string, string>) => ModuleResolveResult} resolveSync | ||
| * @property {(specifier: string, parentURL: string) => any} register | ||
| * @property {() => void} forceLoadHooks | ||
| */ |
Owner
There was a problem hiding this comment.
Ahh, sorry, you can just use CustomizedModuleLoader (the class defined lower in this file).
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
JakobJingleheimer
approved these changes
Jan 10, 2025
JakobJingleheimer
merged commit 9031f3a
into
JakobJingleheimer:esm/fix-jsdoc-getModuleJobForImport
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.