Skip to content

Conversation

@coreyti
Copy link

@coreyti coreyti commented Nov 5, 2011

when rendering JSON with html containing a </textarea> tag, the <textarea> transport would close early. i wrapped the content with a call to #escape_once, which resolves the issue.

  • corey

@JangoSteve
Copy link
Owner

@coreyti, looks good, but I think you may have applied your patch on top of an old version of remotipart, as you wiped out the response_code handling.

@coreyti
Copy link
Author

coreyti commented Nov 5, 2011

@JangoSteve, sorry about that... copy-and-paste mistake (doh!). fixed in the latest commit.

@coreyti
Copy link
Author

coreyti commented Dec 7, 2011

Any thoughts on pulling this in now? I'd love to move back to using your official gem.

@JangoSteve
Copy link
Owner

Hey, sorry @coreyti, been really busy lately. I'll take a look at this and pull it in hopefully.

@BMorearty
Copy link

FWIW, @coreyti's patch fixes the case where a textarea in an AJAX response was breaking my app.

I'll run my full test suite and let you know if it broke anything.

@BMorearty
Copy link

Thumbs up. The full test suite for my app passes without errors after cherry-picking this patch. The test suite has a lot of acceptance specs that use AJAX, several of which invoke remotipart.

@coreyti
Copy link
Author

coreyti commented Feb 3, 2012

hey guys. no worries on the wait... busy here too. glad to hear my change is helping others.

cheers!

@JangoSteve JangoSteve merged commit c4e30df into JangoSteve:master Feb 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants