Skip to content

Javascript Activity Tracker#1

Open
Janluc wants to merge 14 commits intodevelopmentfrom
features
Open

Javascript Activity Tracker#1
Janluc wants to merge 14 commits intodevelopmentfrom
features

Conversation

@Janluc
Copy link
Copy Markdown
Owner

@Janluc Janluc commented Jun 27, 2021

Microverse Project: Javascript To Do

  • A webapp made entirely in Javascript
  • Heavy use of DOM Manipulation
  • Use of 'localstorage' for temporary storage
  • Webpack usage for accessibility.

Copy link
Copy Markdown

@MkrtichSargsyan MkrtichSargsyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Changes Requested ♻️

Hello Janluc Saneaux Rivera

To Highlight 🎉

  1. You added validation for the form
  2. You could add color to each project

However, there are some changes that you need to make in order to get your project approved


  • Kindly add main branch

  • You should have a screenshot in the readme file

  • You should be able to delete a project, after refreshing it again appears

  • Project should be separated into modules.
    Example of a module is const Module = (()=> { const func1 = () => {}; const func2 = () => {}; return {func1, func2}; } )()

  • Necessary run common commands like build, development should be in package.json inside `scripts'.screenshot
    Here is a basic example

    "scripts": {
      "dev": "webpack --mode development",
      "build": "webpack --mode production",
      "start": "webpack-dev-server --mode development --open" // optional
    },
    
  • User can view all projects

  • User can edit the details of a to-do item

Please, make the REQUIRED changes and submit your request again! 😀
Good luck.

ps: . If you have any questions about my review or need help, you can message me on slack ( @MkrtichSargsyan )

Comment thread README.md
- Clone or download repository to local machine
- Run 'npm install' in the terminal to install the packages.
- Run 'npm run build' to build with webpack.
- Run 'npn run start' to open the site in your browser.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly add the start script to package.json or remove this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants